-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot build tests on MSVC #75
Comments
I see. gcc enables M_PI by default as a gnu extension (part of X/Open) In my editor, clang-complete also complains about the missing definition. So defining |
And obviously we should add the building and running the tests to the appveyor config! |
This` should be addressed by 894d1b1. Thanks for reporting! |
MSVC displayed following error when I tried to build vorbis with CMake.
MSVC seems to require
#define _USE_MATH_DEFINES
before#include <math.h>
to useM_PI
.Build succeeded once I add it to L16.
The text was updated successfully, but these errors were encountered: