Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

No audio autoplay in reviews #38

Closed
squasheds opened this issue Jan 5, 2017 · 14 comments
Closed

No audio autoplay in reviews #38

squasheds opened this issue Jan 5, 2017 · 14 comments

Comments

@squasheds
Copy link

It works when doing lessons but when doing reviews, I always have to press the little speaker to get the audio =/. It's not really that big a deal but it would be a nice fix to make it even better :D.

@xiprox
Copy link
Owner

xiprox commented Jan 5, 2017

This is known. Was going to create an issue myself. I'm hoping to get this fixed soon.

@xiprox
Copy link
Owner

xiprox commented Jan 5, 2017

Ok. I managed to reproduce this. However, it looks like this is something to do with wanikani.com and not the app as the same behavior seems to exist in Chrome for Android too.

Anyone can confirm?

@squasheds
Copy link
Author

Confirmed, on two different phones. It works ok with Firefox though.

@AlexDragutu
Copy link
Contributor

This should be fixed in the latest commit. Android's WebView usually has automatic media playback off by default, enabling that flag fixes the issue.

@squasheds
Copy link
Author

Unless this latest commit has yet to come out, I think it wasnt fixed. Im still experiencing the same issue.

Or is this "webview media playback flag" something I can enable in my device?

@xiprox
Copy link
Owner

xiprox commented Mar 7, 2017

@jneapan Yeah, that should be it. But I'm not closing this issue until I test it myself.

@squasheds Nope. The fix was merged just two hours ago and no update with it has been pushed to the Play Store. I have some refactoring work to finish before I push an update though.

@bountin
Copy link

bountin commented Aug 17, 2017

@xiprox Any chance for a release soon? I've managed to build the project myself and the fix is awesome but I'd still like to be back on the store version again, so that I don't miss further updates.

@madmalkav
Copy link

Pleaae release patched version in the store.

@xiprox
Copy link
Owner

xiprox commented Sep 4, 2017

I just pushed this change (along with others) to the alpha channel on the Play Store. Feel free to check it out. Info on alpha testing: https://github.com/xiprox/WaniKani-for-Android#alpha-testing

cc @bountin @madmalkav

@xiprox xiprox closed this as completed Sep 4, 2017
@madmalkav
Copy link

Thanks for the info. When I try to subscribe to the alpha, the link tells me my account isn't qualified.

@xiprox
Copy link
Owner

xiprox commented Sep 4, 2017

Looks like the config on the Play Console had an issue. Fixed and should be working now.

@squasheds
Copy link
Author

works now!

@bountin
Copy link

bountin commented Sep 5, 2017

Great, thank you very much @xiprox !

@maxb
Copy link

maxb commented Oct 12, 2017

It's splendid that there's a fix for this - I just found this issue and switched to the alpha channel.

Don't forget to push it out to the stable channel too! :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants