Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Qitari beast tribe reward #62

Closed
ReidWeb opened this issue Feb 16, 2022 · 4 comments
Closed

Fix Qitari beast tribe reward #62

ReidWeb opened this issue Feb 16, 2022 · 4 comments
Assignees

Comments

@ReidWeb
Copy link
Member

ReidWeb commented Feb 16, 2022

The qitari beast tribe reward is showing as 0. Look into why and apply fix.

Should just require a re-run of the PHP, so a census re-run is not required

@Crakila
Copy link
Member

Crakila commented Feb 16, 2022

Commit ff88575 fixes this as it was not checking for the Qitari beast tribe mount.

Why it didn't pick up on the minion is something I will need to investigate. The mount should be fine for this.

@Crakila
Copy link
Member

Crakila commented Mar 1, 2022

Locally, I tested this by removing the mount check for this and leaving the minion checks and it does work:

$beast_tribes["Qitari"] += in_array("The Behelmeted Serpent of Ronka", $minions) || in_array("The Behatted Serpent of Ronka", $minions) ? 1 : 0;

but on the live site it is not working.

@Pricetx Was there any errors from the php whenever it was being run?

@Crakila
Copy link
Member

Crakila commented Apr 5, 2022

It seems that as of the new census for April 2022, this has not been fixed on live. We'll need to check this again....

@Crakila
Copy link
Member

Crakila commented Jul 3, 2022

This has been resolved and is live on the dev site - https://s3.eu-west-2.amazonaws.com/dev.ffxivcensus.com/index.html
Will be live on the website on next census run.

@Crakila Crakila closed this as completed Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants