Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About Maven #38

Closed
MEILIDEKCL opened this issue Feb 23, 2023 · 8 comments
Closed

About Maven #38

MEILIDEKCL opened this issue Feb 23, 2023 · 8 comments

Comments

@MEILIDEKCL
Copy link

MEILIDEKCL commented Feb 23, 2023

When I try to build the hdfs project following the given scripts, but I don't get the right results. In ~/app/ctest-hadoop/hadoop-hdfs-project/hadoop-hdfs/target/classes directory, there is no core-ctest.xml which I have built in hadoop-common.
I have tried to find the reason, but nothing has been gained.I deteled the .m2 directory, but it doesn't work.
So, do you have any suggestions for me? Thank you so much.

@xylian86
Copy link
Collaborator

@MEILIDEKCL Thanks for the questions.

The potential solutions are:

  1. Please check whether the hadoop is in the ctest-injection branch
  2. The name of the file for injection for hdfs is hdfs-ctest.xml instead of core-ctest.xml.
  3. And you need to build the hdfs module so that the hdfs-ctest.xml in src will be copied to target.

@MEILIDEKCL
Copy link
Author

@Alex-Lian Thanks for your response.

  1. I am surely in the ctest-injection branch
  2. Yes, hdfs project need hdfs-ctest.xml. But I find that in your source code(ctest_const.py), the INJECTION_PATH for HDFS needs two xml (core-ctest.xml and hdfs-ctest.xml)
  3. I followed the scripts add_project.sh ctest gived

@xylian86
Copy link
Collaborator

@MEILIDEKCL I think it is a bug in the ctest_const.py. For hdfs, we only need to inject value to hdfs-ctest.xml file. I need to double check with @marshtompsxd.

@MEILIDEKCL
Copy link
Author

@Alex-Lian Thanks for your help.

@marshtompsxd
Copy link
Member

marshtompsxd commented Feb 26, 2023

We found some test cases in HDFS does not load hdfs-xxx.xml so we injected to both to make sure the injection takes effect. In most cases, injecting to hdfs-ctest.xml should be enough for HDFS.

@MEILIDEKCL
Copy link
Author

@marshtompsxd Yeah, Thank you. But is there any questions for buliding the project on HDFS? I mean why core-ctest.xml wasn't compiled into target/class directory? Thank you.

@xylian86
Copy link
Collaborator

@MEILIDEKCL For Hcommon, the filename for injection is core-ctest.xml. While for HDFS, the filename is hdfs-ctest.xml.

And you can find the hdfs-ctest.xml file here. https://github.com/xlab-uiuc/hadoop/tree/ctest-injection/hadoop-hdfs-project/hadoop-hdfs/src/main/resources

@MEILIDEKCL
Copy link
Author

Oh, yeah. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants