Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements on Slooo #39

Closed
Essoz opened this issue Feb 16, 2022 · 8 comments
Closed

Improvements on Slooo #39

Essoz opened this issue Feb 16, 2022 · 8 comments
Assignees

Comments

@Essoz
Copy link
Collaborator

Essoz commented Feb 16, 2022

I know discussing slooo improvements might be premature given that my assignment has not been finished yet. I just don't want my ideas from my experience testing the systems to go away:

Possible Improvements
1. Sandbox for local mode: When running in local mode, slooo should sandbox node instances in order to
1. provide more kinds faults in local mode -- for example, disks, network devices can be simulated and thus we can inject disk and network slowness.
2. get rid of sudoers
3. avoid interference with local environment.
*I am not sure whether the current docker solution is good enough or there are better solutions. Ideally, I think we should provide individualized control over each node, but I am not sure whether it is worth doing so.

  1. Better Result Naming Conventions: Slowness config should be included in the folder name so that we don't have to manage results manually.
  2. Reduce Command-line Output: Some commandline outputs (like cgdelete errors before benchmark is run) could be eliminated / redirected to some log file because those outputs are massive and not meaningful before benchmark is run.
  3. System Usage Recording: This is proposed by Varishith and he is working on this improvement.
@tianyin
Copy link
Member

tianyin commented Feb 17, 2022

#1 is a huge rewrite. I won't suggest that. Docker is essentially cgroup plus a bunch of things so I don't think it's truly necessary to use Docker.

#2 #3 I don't precisely know what it is, but automation is always a good idea.

#4 is a very good idea. I hope to see a proposal on how you are going to do it.

@varshith15
Copy link
Collaborator

varshith15 commented Feb 25, 2022

I think we should also have a code overhaul, make the code look cleaner using object-oriented programming. Redesigning the complete structure of the code. right now the code still looks more scriptyy
I think this is more important than other features. @tianyin @Essoz

@tianyin
Copy link
Member

tianyin commented Feb 25, 2022

@varshith15 I don't exactly know what's your vision -- it sounds good but also quite abstract.

~t

@varshith15
Copy link
Collaborator

@tianyin I was just looking at code in here https://piazza.com/class/kyd945rv1gt2t?cid=83
It looks so clean and super understandable. I want to make slooo to look similar.

@tianyin
Copy link
Member

tianyin commented Feb 25, 2022

hehe, glad you are inspired by the student's code.

improving code quality is always a good idea, but I'm not 100% sure you can write the code using xonsh.

@varshith15
Copy link
Collaborator

Yes, It won't be as simple with xonsh.

@Essoz
Copy link
Collaborator Author

Essoz commented Feb 25, 2022

I agree with making the code cleaner. But i am not sure how we are going to make the tool look like since it is really going to be a huge rewrite. @varshith15

@Essoz
Copy link
Collaborator Author

Essoz commented Feb 28, 2022

@varshith15
I have a confusion. Since the student code is implemented using Python, why using xonsh could make things harder?

I think its necessary for us to discuss what to do next, set a clear goal and a serious action plan in order to push this forward. Tianyin asked for a proposal for the system usage recording feature and proposed another feature in #40 . Maybe we can discuss which one to do first. And I totally agree with reorganizing the code, but I think we need to go pass that pretty quickly and solidly to work on further improvements.

This was referenced Mar 5, 2022
@tianyin tianyin closed this as completed Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants