Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Instrument the execution path of the command (i.e. fast_path or slow_path) #580

Open
1 task done
iGxnon opened this issue Dec 19, 2023 · 6 comments · May be fixed by #682
Open
1 task done

[Feature]: Instrument the execution path of the command (i.e. fast_path or slow_path) #580

iGxnon opened this issue Dec 19, 2023 · 6 comments · May be fixed by #682
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@iGxnon
Copy link
Contributor

iGxnon commented Dec 19, 2023

Description about the feature

Instrument the execution path of the command (i.e. fast_path or slow_path).
Beneficial for debugging.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@iGxnon iGxnon added the enhancement New feature or request label Dec 19, 2023
@iGxnon
Copy link
Contributor Author

iGxnon commented Dec 19, 2023

Nice to have a try with: await-tree

@iGxnon iGxnon mentioned this issue Dec 19, 2023
@iGxnon iGxnon added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 20, 2023
@LingKa28 LingKa28 self-assigned this Jan 2, 2024
@LingKa28 LingKa28 removed their assignment Feb 17, 2024
@Harsh1s
Copy link

Harsh1s commented Mar 2, 2024

Hello there @iGxnon ! I'd like working on this issue. Could I be assigned this? Also, what exactly does "instrument" mean here?

@iGxnon
Copy link
Contributor Author

iGxnon commented Mar 3, 2024

Hello there @iGxnon ! I'd like working on this issue. Could I be assigned this? Also, what exactly does "instrument" mean here?

Greate to have you on board! There is a macros call instrument in tracing. It could be used to instrument a function every time it is called. So "instrument" here is similar to "log".
Currently, we have logged some simple information to display the execution path of the command. We hope to use more detailed information to show this process (i.e. use await-tree to indicate the duration of each await.).

@GFX9
Copy link
Contributor

GFX9 commented Mar 4, 2024

Let me try

@Harsh1s
Copy link

Harsh1s commented Mar 4, 2024

Let me try

Although you are free to do so, I think it would be better if you tried some other issue as it could mean wasted efforts from one side.

@GFX9
Copy link
Contributor

GFX9 commented Mar 4, 2024

Let me try

Although you are free to do so, I think it would be better if you tried some other issue as it could mean wasted efforts from one side.

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
4 participants