Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raise exception in case of jagged arrays #942

Merged
merged 1 commit into from Oct 21, 2018
Merged

raise exception in case of jagged arrays #942

merged 1 commit into from Oct 21, 2018

Conversation

fzumstein
Copy link
Member

No description provided.

Colin-b
Colin-b reviewed Oct 2, 2018
View reviewed changes
Copy link
Contributor

@Colin-b Colin-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't it introduce a performance drop on huge volume of data ? Also in the same situation, wouldn't it be faster to compute the length of the first row only once (or is it a fast enough computation?)

Candid questions here

@fzumstein fzumstein force-pushed the jagged-array-check branch 3 times, most recently from f49bc59 to ee239c7 Compare October 2, 2018 21:55
@fzumstein fzumstein added this to the v0.13.0 milestone Oct 21, 2018
@fzumstein fzumstein merged commit 6970932 into master Oct 21, 2018
@fzumstein
Copy link
Member Author

I'd expect most users to work with numpy/pandas when using huge data. If it turns out to be an issue we can always roll back.

@fzumstein fzumstein deleted the jagged-array-check branch October 22, 2018 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Colin-b Colin-b Colin-b left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fzumstein @Colin-b