Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphical menu configuration does not show all options #1035

Closed
jonathanpoelen opened this issue Nov 14, 2020 · 13 comments
Closed

Graphical menu configuration does not show all options #1035

jonathanpoelen opened this issue Nov 14, 2020 · 13 comments
Milestone

Comments

@jonathanpoelen
Copy link
Contributor

When there are many options and/or the window is too small, not all options can be displayed. Unfortunately, there is no scroll.

Menu Config

a

31 options, but no scroll. After control_flow, the focus goes back to msvc_isystem.
Window resizing is also ignored.

Value selector

b

20 values, the focus can cycle through them all, but the rendering does not change. Here, the focus is on an displayed value.

Help and Search menu

c

Ok, scroll present and functional.

@waruqi waruqi added this to the v2.3.9 milestone Nov 14, 2020
@waruqi
Copy link
Member

waruqi commented Nov 14, 2020

This requires adding a scroll bar in the menuconf view, and I will consider supporting it in future versions.

@waruqi
Copy link
Member

waruqi commented Nov 16, 2020

xmake 2.3.9 will be released soon, I will improve the support rolling issue in the next version.

@waruqi waruqi modified the milestones: v2.3.9, v2.5.1 Nov 16, 2020
@waruqi
Copy link
Member

waruqi commented Nov 20, 2020

Although I have not yet supported scrolling for the menuconf/choicebox view, I have added support for mouse events. on dev branch.

@waruqi
Copy link
Member

waruqi commented Nov 29, 2020

I have added scrollbar to support it on dev branch. xmake update -s dev

@waruqi
Copy link
Member

waruqi commented Nov 29, 2020

Snip20201129_20

@jonathanpoelen
Copy link
Contributor Author

Few bugs:

  • <Back> button does not work after a scrolling to the next page (basic config -> scroll to the second page -> back -> ???). Then there is an error with <Select> button.
error: @programdir/core/ui/menuconf.lua:247: attempt to index local 'item' (a nil value)
  • Key up is not circular, it is positioned at the last item of the first page rather than the last item of the last page.
  • Option list is empty when it is reopened after a scroll (basic config -> platform -> scroll to second page -> cancel -> reopen)
  • Scrolling is invisible in the help widget.

It would be nice if page up/down scrolls to the next/previous page.

@waruqi
Copy link
Member

waruqi commented Nov 30, 2020

Back button does not work after a scrolling to the next page (basic config -> scroll to the second page -> back -> ???). Then there is an error with Select button.

I will fix it later.

Key up is not circular, it is positioned at the last item of the first page rather than the last item of the last page.

This will be more complicated to implement, I don’t have time to improve it now, just the current list loop is acceptable.

Option list is empty when it is reopened after a scroll (basic config -> platform -> scroll to second page -> cancel -> reopen)

I will look at it.

It would be nice if page up/down scrolls to the next/previous page.

I don’t have these two key buttons on my keyboard, so I can’t test it.

Scrolling is invisible in the help widget.

It works for me, the scroll bar is only displayed when the text is not fully displayed

Snip20201130_21

@waruqi
Copy link
Member

waruqi commented Nov 30, 2020

Back button does not work after a scrolling to the next page (basic config -> scroll to the second page -> back -> ???). Then there is an error with Select button.

I have fixed it on dev branch.

@waruqi
Copy link
Member

waruqi commented Nov 30, 2020

Option list is empty when it is reopened after a scroll (basic config -> platform -> scroll to second page -> cancel -> reopen)

I have also fixed it.

@waruqi
Copy link
Member

waruqi commented Nov 30, 2020

It would be nice if page up/down scrolls to the next/previous page.

I have added it, but I cannot test it.

@jonathanpoelen
Copy link
Contributor Author

I don’t have these two key buttons on my keyboard, so I can’t test it.

If you have Linux, there are tools like xdotools that can simulate key (xdotool key Page_Up).

Scrolling is invisible in the help widget.
It works for me, the scroll bar is only displayed when the text is not fully displayed

Ah, it seems that it was only after a resize (xmake f --menu -> resize -> basic conf -> platform -> help -> possibly no scrollbar in help)

Back button does not work after a scrolling to the next page (basic config -> scroll to the second page -> back -> ???). Then there is an error with Select button.

I have fixed it on dev branch.

Option list is empty when it is reopened after a scroll (basic config -> platform -> scroll to second page -> cancel -> reopen)

I have also fixed it.

I confirm.

It would be nice if page up/down scrolls to the next/previous page.

I have added it, but I cannot test it.

e.key_name == "PageDown" or e.key_name == "PageUp" is missing in mconfdialog:on_event and mconfdialog:on_event, but the behavior is unnatural. I will do a PR when I have time.

@waruqi
Copy link
Member

waruqi commented Dec 1, 2020

Ah, it seems that it was only after a resize (xmake f --menu -> resize -> basic conf -> platform -> help -> possibly no scrollbar in help)

Oh, I works for me, I still can't reproduce it.

@waruqi
Copy link
Member

waruqi commented Dec 4, 2020

I cannot reproduce other issues at the moment, so I can only close this issue first.

@waruqi waruqi closed this as completed Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants