Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for windows .manifest files through the add_files interface. #1241

Closed
Force67 opened this issue Feb 13, 2021 · 4 comments
Closed

Comments

@Force67
Copy link

Force67 commented Feb 13, 2021

Windows .manifest files should be supported through the add_files interface, similar to how .rc files are handeled.

@waruqi waruqi added this to the v2.5.2 milestone Feb 13, 2021
@waruqi
Copy link
Member

waruqi commented Feb 18, 2021

I think you can use add_ldflags directly. add_ldflags("/manifest", "/ManifestFile:\"xxx.manifest\"")

@waruqi
Copy link
Member

waruqi commented Feb 21, 2021

Can you provide a demo project with manifest file?

@waruqi
Copy link
Member

waruqi commented Feb 22, 2021

I have supported it. https://github.com/xmake-io/xmake/blob/dev/tests/projects/c++/manifest/xmake.lua

add_rules("mode.debug", "mode.release")
target("test")
    set_kind("binary")
    add_files("src/*.cpp")
    add_files("src/*.manifest")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants