-
-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order of Toolchain Flags and User Flags in Compilation Process #978
Comments
Not exactly, |
I am talking about compilations flags, not commands. Compilation in the meaning they change the output of the compilation and not what's getting in. |
? What I’m also talking about is compilation flags ( |
I think compilation flags should be separated into:
On top of that we have complication definition and input files. Compilation Flags are the defaults of |
I will try to improve the order, but the search path is also part of the compiled flags, and there is currently no way to separate them. |
When you say no way to separate them you mean in the current code of Rethinking it, I think a better partition would be:
I think |
I have improved their order and separated compilation flags and seachdirs/links. You can update to the dev version and try it again. |
Dose it work? I have improved it. |
Is it also on the build form the CI? |
we can also only update lua scripts.
|
I will wait for a fix for #977 (comment) and will check them both at once. |
Tested it and on the few examples I ran indeed the user flags were after the default flags. Any chance for |
|
At the moment, according to
Gitter
talk:I think this policy, for the compilation process should be changed. The order should be user flags (By
add_cflags()
orset_cflags()
and their extension to other languages) are the last.The logic is that in most (All?) compilers the last flags are the one to override preceding ones.
Hence it means the user will be able to set the flags one wants and override defaults.
An example is using the 32 Bit Pointers math in 64 bit mode under
MinGW
forx64
.The user cat set
add_cxflags("-mx32")
, namely the user wants to use 32 Bit pointers in 64 Bit programs. Yet since-m64
as the default toolchain flag will be last it will override the user flags.The text was updated successfully, but these errors were encountered: