Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit persons name #49

Open
silverbucket opened this issue Nov 9, 2013 · 5 comments
Open

edit persons name #49

silverbucket opened this issue Nov 9, 2013 · 5 comments

Comments

@silverbucket
Copy link

I accidently entered someones name wrong, and see no way to correct it without discarding the transactions

@xMartin
Copy link
Owner

xMartin commented Nov 9, 2013

true, there's no way to remove or change a misspelled name. but you can just add it again correctly and leave the wrong one unchecked. this way it is not added at all. there's no way to remove someone. just not checking it.

will think about this problem.

@silverbucket
Copy link
Author

what about when you are in the people list view, and click a name, an edit
link pops up next to it, which you can click for an inline-edit ?

this way a single finger tap doesn't automatically enter edit mode, so you
dont unintentionally edit someones name, but you can still do it.

i dont like the idea of just creating a new person entry, because if the
previous person already has a history you have manually go back and switch
it

On Sat, Nov 9, 2013 at 5:25 PM, xMartin notifications@github.com wrote:

true, there's no way to remove or change a misspelled name. but you can
just add it again correctly and leave the wrong one unchecked. this way it
is not added at all. there's no way to remove someone. just not checking it.

will think about this problem.


Reply to this email directly or view it on GitHubhttps://github.com//issues/49#issuecomment-28130703
.

@xMartin
Copy link
Owner

xMartin commented Nov 9, 2013

Why would you want to change a person's name in the people/balance view?

Hm, maybe that is a bit confusing. It is actually the balance view and not the place to deal with people (at least in my concept). But of course that comes to mind when it's called "people". Currently people are participants of a transactions and summed up to participants in a tab. So changing someones name is done in the transaction. I have to think about the mental model more...

@jancborchardt
Copy link
Collaborator

Name changes should probably be possible in the future per-person breakdown. It’s a rare case but it should probably be possible.

And yes it belongs to the »People«(Balance) view. That’s the place to deal with people because that’s the one list where all people are in.

@xMartin
Copy link
Owner

xMartin commented Nov 30, 2013

What is this about? Changing a name including all previous transactions because the nickname of someone changed or something or just fixing a typo in one transaction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants