Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change navigate name to route #1

Merged
merged 1 commit into from Oct 4, 2021
Merged

Change navigate name to route #1

merged 1 commit into from Oct 4, 2021

Conversation

f7deleon
Copy link
Member

@f7deleon f7deleon commented Oct 4, 2021

Changed navigate() to route() and route to url for more clarity.

Also added TypedNavigationInterface0 so TypedNavigation.E has a route() function and it's not added to the other implementations.

@f7deleon f7deleon requested a review from a team as a code owner October 4, 2021 17:19
@f7deleon f7deleon requested a review from mirland October 4, 2021 17:19
@f7deleon f7deleon merged commit 47c75f3 into main Oct 4, 2021
@f7deleon f7deleon deleted the feature/renamed-navigate-to-route branch October 4, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirland mirland mirland approved these changes

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@f7deleon @mirland