Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use credential service account file path instead of a credential file #44

Merged
merged 5 commits into from
Oct 10, 2019
Merged

Use credential service account file path instead of a credential file #44

merged 5 commits into from
Oct 10, 2019

Conversation

mirland
Copy link
Collaborator

@mirland mirland commented Oct 10, 2019

Comments

  • The main change is to validate the credentials only when the deploy task is executed.
  • serviceAccountCredentials = file("your-key.json") or serviceAccountCredentials = "your-key.json" can be used in the same way

@mirland mirland marked this pull request as ready for review October 10, 2019 13:54
@mirland mirland requested a review from a team as a code owner October 10, 2019 13:54
@mirland mirland merged commit 626e386 into feature/firebase-app-distribution Oct 10, 2019
@mirland mirland deleted the feature/change-credential-file-to-file-path branch October 10, 2019 20:09
mirland added a commit that referenced this pull request Oct 15, 2019
@mirland
Use credential service account file path instead of a credential file (…
0712e17 
…#44)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f7deleon f7deleon f7deleon approved these changes

@FerrariBruno FerrariBruno FerrariBruno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mirland @f7deleon @FerrariBruno