Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Contextual Toolbar #26

Closed
AnthonyMDev opened this issue May 9, 2015 · 3 comments
Closed

[Feature] Contextual Toolbar #26

AnthonyMDev opened this issue May 9, 2015 · 3 comments

Comments

@AnthonyMDev
Copy link

I'm implementing a UIToolbar that sits at the bottom of my tab strip that changes its items based upon which child page is displayed.

If I created a pull request to add this to the repository, would it get accepted?

@michaelEllisUy
Copy link
Contributor

Hey Anthony,
You could send us your implementation and we could add it to the documentation as an example. XLPagerTabStrip wasn't originally intended to support this.

@AnthonyMDev
Copy link
Author

My current implementation actually has an issue that would be solved by #38.

I'm going to try and make a PR that closes #38 and after that, I'll send you an example of my implementation for the toolbar!

Thanks!

@AnthonyMDev
Copy link
Author

I've made PR #53 which will close #38 and allow me to finish my toolbar implementation. Then I will be happy to send you a demo of the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants