Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial - added func in Fanout Handler Setup #179

Merged
merged 3 commits into from
Oct 12, 2022
Merged

Conversation

mtrinh11
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #179 (5baf683) into main (1bada58) will decrease coverage by 1.22%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
- Coverage   25.04%   23.81%   -1.23%     
==========================================
  Files           7        7              
  Lines         603      634      +31     
==========================================
  Hits          151      151              
- Misses        450      481      +31     
  Partials        2        2              
Flag Coverage Δ
unittests 23.81% <0.00%> (-1.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
primaryHandler.go 0.00% <0.00%> (ø)

Copy link
Collaborator

@johnabass johnabass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great start!

@mtrinh11 mtrinh11 removed the request for review from denopink July 1, 2022 17:24
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mtrinh11
Copy link
Contributor Author

addresses #34

Copy link
Member

@renaz6 renaz6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@denopink denopink merged commit 752064e into main Oct 12, 2022
@denopink denopink deleted the BeforeFanoutHandler branch October 12, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants