Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document.canonicalize(comments) only supports XML_C14N_1_1 #22

Closed
pederbl opened this issue Jul 1, 2011 · 7 comments
Closed

document.canonicalize(comments) only supports XML_C14N_1_1 #22

pederbl opened this issue Jul 1, 2011 · 7 comments

Comments

@pederbl
Copy link

pederbl commented Jul 1, 2011

libxml-ruby only supports XML_C14N_1_1 canonicalization mode. libxml2 also supports XML_C14N_1_0 and XML_C14N_EXCLUSIVE_1_0. I need XML_C14N_EXCLUSIVE_1_0 support and would like to add it. It seems like a small fix should be enough to fix this.

I need help to figure out how to run the test suite. When I run "rake test", I get the following error:

$ rake test
rake/rdoctask is deprecated. Use rdoc/task instead (in RDoc 2.4.2+)
/usr/local/lib/ruby/1.9.1/rdoc/task.rb:30: warning: already initialized constant Task
WARNING: Global access to Rake DSL methods is deprecated. Please include
... Rake::DSL into classes and modules which use the Rake DSL methods.
WARNING: DSL method Grancher::Task#desc called at /usr/local/lib/ruby/gems/1.9.1/gems/grancher-0.1.5/lib/grancher/task.rb:21:in define_task' WARNING: DSL method Grancher::Task#task called at /usr/local/lib/ruby/gems/1.9.1/gems/grancher-0.1.5/lib/grancher/task.rb:22:indefine_task'
/usr/local/bin/ruby -I"lib:test" -I"/usr/local/lib/ruby/gems/1.9.1/gems/rake-0.9.2/lib" "/usr/local/lib/ruby/gems/1.9.1/gems/rake-0.9.2/lib/rake/rake_test_loader.rb" "test/test*.rb"
internal:lib/rubygems/custom_require:29:in require': no such file to load -- libxml_ruby (LoadError) from <internal:lib/rubygems/custom_require>:29:inrequire'
from /home/ec2-user/libxml-ruby/lib/libxml.rb:8:in rescue in <top (required)>' from /home/ec2-user/libxml-ruby/lib/libxml.rb:4:in<top (required)>'
from internal:lib/rubygems/custom_require:29:in require' from <internal:lib/rubygems/custom_require>:29:inrequire'
from /home/ec2-user/libxml-ruby/lib/xml.rb:13:in <top (required)>' from <internal:lib/rubygems/custom_require>:29:inrequire'
from internal:lib/rubygems/custom_require:29:in require' from /home/ec2-user/libxml-ruby/test/test_helper.rb:13:in<top (required)>'
from internal:lib/rubygems/custom_require:29:in require' from <internal:lib/rubygems/custom_require>:29:inrequire'
from /home/ec2-user/libxml-ruby/test/tc_attr.rb:3:in <top (required)>' from <internal:lib/rubygems/custom_require>:29:inrequire'
from internal:lib/rubygems/custom_require:29:in require' from /home/ec2-user/libxml-ruby/test/test_suite.rb:8:in<top (required)>'
from internal:lib/rubygems/custom_require:29:in require' from <internal:lib/rubygems/custom_require>:29:inrequire'
from /usr/local/lib/ruby/gems/1.9.1/gems/rake-0.9.2/lib/rake/rake_test_loader.rb:9:in block (2 levels) in <main>' from /usr/local/lib/ruby/gems/1.9.1/gems/rake-0.9.2/lib/rake/rake_test_loader.rb:9:ineach'
from /usr/local/lib/ruby/gems/1.9.1/gems/rake-0.9.2/lib/rake/rake_test_loader.rb:9:in block in <main>' from /usr/local/lib/ruby/gems/1.9.1/gems/rake-0.9.2/lib/rake/rake_test_loader.rb:5:ineach'
from /usr/local/lib/ruby/gems/1.9.1/gems/rake-0.9.2/lib/rake/rake_test_loader.rb:5:in `

'
rake aborted!
Command failed with status (1): [/usr/local/bin/ruby -I"lib:test" -I"/usr/l...]

Tasks: TOP => test
(See full trace by running task with --trace)

$ ruby --version
ruby 1.9.2p180 (2011-02-18 revision 30909) [i686-linux]

Thanks,
Peder

@cfis
Copy link
Member

cfis commented Jul 9, 2011

Error message says libxml_ruby doesn't exist. That is the .so file. Have you successfully built the gem?

@pederbl
Copy link
Author

pederbl commented Jul 9, 2011

Sorry for putting two problems in the same issue. The main issue here is actually the lack of full support for canonicalisation.

@cfis
Copy link
Member

cfis commented Jul 9, 2011

Ok. So on the canonicalisation issue, that code was added a couple months ago via a pull request. I'm happy to accept a patch that add support for all of libxml2's canonicalisation modes. Would you be interested in putting one together?

Charlie

@cfis
Copy link
Member

cfis commented Jul 18, 2011

Just following up on this, still interested?

@pederbl
Copy link
Author

pederbl commented Jul 18, 2011

Thanks for following up. Unfortunately, I'm tied up in other things now.

@cfis
Copy link
Member

cfis commented Jul 19, 2011

Ok, let me know if you want to reopen.

@cfis
Copy link
Member

cfis commented Aug 4, 2013

Since this is so old, going to close.

@cfis cfis closed this as completed Aug 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants