Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIT license is not complete #173

Closed
j-buckland opened this issue Jan 15, 2021 · 1 comment · Fixed by #178
Closed

MIT license is not complete #173

j-buckland opened this issue Jan 15, 2021 · 1 comment · Fixed by #178
Labels
bug Something isn't working
Milestone

Comments

@j-buckland
Copy link

Issue

An MIT license usually includes a copyright statement. The template which is linked to here https://github.com/xmldom/xmldom/blob/master/LICENSE.md is only a template. Most libraries I've seen use a LICENSE file with the copyright details filled in (see restify as an example.

Proposed solution

It would really help to be able to link to a file in your repo with the complete license text to make attributing and open source acknowledgements easier.

@brodybits brodybits added the bug Something isn't working label Jan 17, 2021
@brodybits
Copy link
Member

I would favor dropping the LPGL option, as I said in #172, and using the standard MIT text in the license file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants