perf(core): upgrade to es2018

xmlking · Dec 8, 2018 · e525738 · e525738
1 parent 7c899a3
commit e525738
Show file tree

Hide file tree

Showing 38 changed files with 171 additions and 302 deletions.
diff --git a/libs/animations/tsconfig.lib.json b/libs/animations/tsconfig.lib.json
@@ -12,16 +12,15 @@
     "experimentalDecorators": true,
     "importHelpers": true,
     "types": [],
-    "lib": ["dom", "es2015"]
+    "lib": ["dom", "es2018"]
   },
   "angularCompilerOptions": {
     "annotateForClosureCompiler": true,
     "skipTemplateCodegen": true,
     "strictMetadataEmit": true,
     "fullTemplateTypeCheck": true,
     "strictInjectionParameters": true,
-    "flatModuleId": "AUTOGENERATED",
-    "flatModuleOutFile": "AUTOGENERATED"
+    "enableResourceInlining": true
   },
   "exclude": ["src/test.ts", "**/*.spec.ts"]
 }
diff --git a/libs/app-confirm/tsconfig.lib.json b/libs/app-confirm/tsconfig.lib.json
@@ -12,16 +12,15 @@
     "experimentalDecorators": true,
     "importHelpers": true,
     "types": [],
-    "lib": ["dom", "es2015"]
+    "lib": ["dom", "es2018"]
   },
   "angularCompilerOptions": {
     "annotateForClosureCompiler": true,
     "skipTemplateCodegen": true,
     "strictMetadataEmit": true,
     "fullTemplateTypeCheck": true,
     "strictInjectionParameters": true,
-    "flatModuleId": "AUTOGENERATED",
-    "flatModuleOutFile": "AUTOGENERATED"
+    "enableResourceInlining": true
   },
   "exclude": ["src/test.ts", "**/*.spec.ts"]
 }
diff --git a/libs/auth/tsconfig.lib.json b/libs/auth/tsconfig.lib.json
@@ -12,16 +12,15 @@
     "experimentalDecorators": true,
     "importHelpers": true,
     "types": [],
-    "lib": ["dom", "es2015"]
+    "lib": ["dom", "es2018"]
   },
   "angularCompilerOptions": {
     "annotateForClosureCompiler": true,
     "skipTemplateCodegen": true,
     "strictMetadataEmit": true,
     "fullTemplateTypeCheck": true,
     "strictInjectionParameters": true,
-    "flatModuleId": "AUTOGENERATED",
-    "flatModuleOutFile": "AUTOGENERATED"
+    "enableResourceInlining": true
   },
   "exclude": ["src/test.ts", "**/*.spec.ts"]
 }
diff --git a/libs/breadcrumbs/tsconfig.lib.json b/libs/breadcrumbs/tsconfig.lib.json
@@ -12,16 +12,15 @@
     "experimentalDecorators": true,
     "importHelpers": true,
     "types": [],
-    "lib": ["dom", "es2015"]
+    "lib": ["dom", "es2018"]
   },
   "angularCompilerOptions": {
     "annotateForClosureCompiler": true,
     "skipTemplateCodegen": true,
     "strictMetadataEmit": true,
     "fullTemplateTypeCheck": true,
     "strictInjectionParameters": true,
-    "flatModuleId": "AUTOGENERATED",
-    "flatModuleOutFile": "AUTOGENERATED"
+    "enableResourceInlining": true
   },
   "exclude": ["src/test.ts", "**/*.spec.ts"]
 }
diff --git a/libs/chat-box/tsconfig.lib.json b/libs/chat-box/tsconfig.lib.json
@@ -12,16 +12,15 @@
     "experimentalDecorators": true,
     "importHelpers": true,
     "types": [],
-    "lib": ["dom", "es2015"]
+    "lib": ["dom", "es2018"]
   },
   "angularCompilerOptions": {
     "annotateForClosureCompiler": true,
     "skipTemplateCodegen": true,
     "strictMetadataEmit": true,
     "fullTemplateTypeCheck": true,
     "strictInjectionParameters": true,
-    "flatModuleId": "AUTOGENERATED",
-    "flatModuleOutFile": "AUTOGENERATED"
+    "enableResourceInlining": true
   },
   "exclude": ["src/test.ts", "**/*.spec.ts"]
 }
diff --git a/libs/clap/tsconfig.lib.json b/libs/clap/tsconfig.lib.json
@@ -12,16 +12,15 @@
     "experimentalDecorators": true,
     "importHelpers": true,
     "types": [],
-    "lib": ["dom", "es2015"]
+    "lib": ["dom", "es2018"]
   },
   "angularCompilerOptions": {
     "annotateForClosureCompiler": true,
     "skipTemplateCodegen": true,
     "strictMetadataEmit": true,
     "fullTemplateTypeCheck": true,
     "strictInjectionParameters": true,
-    "flatModuleId": "AUTOGENERATED",
-    "flatModuleOutFile": "AUTOGENERATED"
+    "enableResourceInlining": true
   },
   "exclude": ["src/test.ts", "**/*.spec.ts"]
 }
diff --git a/libs/context-menu/tsconfig.lib.json b/libs/context-menu/tsconfig.lib.json
@@ -12,16 +12,15 @@
     "experimentalDecorators": true,
     "importHelpers": true,
     "types": [],
-    "lib": ["dom", "es2015"]
+    "lib": ["dom", "es2018"]
   },
   "angularCompilerOptions": {
     "annotateForClosureCompiler": true,
     "skipTemplateCodegen": true,
     "strictMetadataEmit": true,
     "fullTemplateTypeCheck": true,
     "strictInjectionParameters": true,
-    "flatModuleId": "AUTOGENERATED",
-    "flatModuleOutFile": "AUTOGENERATED"
+    "enableResourceInlining": true
   },
   "exclude": ["src/test.ts", "**/*.spec.ts"]
 }
diff --git a/libs/core/tsconfig.lib.json b/libs/core/tsconfig.lib.json
@@ -12,16 +12,15 @@
     "experimentalDecorators": true,
     "importHelpers": true,
     "types": [],
-    "lib": ["dom", "es2015"]
+    "lib": ["dom", "es2018"]
   },
   "angularCompilerOptions": {
     "annotateForClosureCompiler": true,
     "skipTemplateCodegen": true,
     "strictMetadataEmit": true,
     "fullTemplateTypeCheck": true,
     "strictInjectionParameters": true,
-    "flatModuleId": "AUTOGENERATED",
-    "flatModuleOutFile": "AUTOGENERATED"
+    "enableResourceInlining": true
   },
   "exclude": ["src/test.ts", "**/*.spec.ts"]
 }
diff --git a/libs/dashboard/src/lib/containers/dashboard-layout/dashboard-layout.component.ts b/libs/dashboard/src/lib/containers/dashboard-layout/dashboard-layout.component.ts
@@ -10,6 +10,7 @@ import { environment } from '@env/environment';
 import { RouterState } from '@ngxs/router-plugin';
 import { map } from 'rxjs/operators';
 import { WINDOW } from '@ngx-starter-kit/core';
+import { untilDestroy } from '@ngx-starter-kit/ngx-utils';
 
 @Component({
   selector: 'ngx-dashboard-layout',
@@ -20,12 +21,7 @@ import { WINDOW } from '@ngx-starter-kit/core';
   // encapsulation: ViewEncapsulation.None
 })
 export class DashboardLayoutComponent implements OnInit, OnDestroy {
-  @ViewChild('sidenav')
-  sidenav;
-
-  private _mediaSubscription: Subscription;
-  private _routerEventsSubscription: Subscription;
-
+  @ViewChild('sidenav') sidenav;
   quickpanelOpen = false;
   sidenavOpen = true;
   sidenavMode = 'side';
@@ -43,21 +39,25 @@ export class DashboardLayoutComponent implements OnInit, OnDestroy {
   ) {}
 
   ngOnInit() {
-    this.crumbs$ = this.store
-      .select<any>(RouterState.state)
-      .pipe(map(state => Array.from(state.breadcrumbs, ([key, value]) => ({ name: key, link: '/' + value }))));
+    this.crumbs$ = this.store.select<any>(RouterState.state).pipe(
+      untilDestroy(this),
+      map(state => Array.from(state.breadcrumbs, ([key, value]) => ({ name: key, link: '/' + value }))),
+    );
 
     this.depth$ = this.store.select<any>(RouterState.state).pipe(map(state => state.data.depth));
 
-    this._mediaSubscription = this.media.subscribe((change: MediaChange) => {
-      const isMobile = change.mqAlias === 'xs' || change.mqAlias === 'sm';
+    this.media
+      .asObservable()
+      .pipe(untilDestroy(this))
+      .subscribe((change: MediaChange) => {
+        const isMobile = change.mqAlias === 'xs' || change.mqAlias === 'sm';
 
-      this.isMobile = isMobile;
-      this.sidenavMode = isMobile ? 'over' : 'side';
-      this.sidenavOpen = !isMobile;
-    });
+        this.isMobile = isMobile;
+        this.sidenavMode = isMobile ? 'over' : 'side';
+        this.sidenavOpen = !isMobile;
+      });
 
-    this._routerEventsSubscription = this.router.events.subscribe(event => {
+    this.router.events.pipe(untilDestroy(this)).subscribe(event => {
       if (event instanceof NavigationEnd && this.isMobile) {
         this.sidenav.close();
       }
@@ -79,12 +79,6 @@ export class DashboardLayoutComponent implements OnInit, OnDestroy {
   }
 
   ngOnDestroy() {
-    this._mediaSubscription.unsubscribe();
     this.store.dispatch(new DisconnectWebSocket());
   }
-
-  getRouteDepth(outlet) {
-    return outlet.activatedRouteData['depth'] || 1;
-    // return outlet.isActivated ? outlet.activatedRoute : ''
-  }
 }
diff --git a/libs/dashboard/src/lib/dashboard.module.ts b/libs/dashboard/src/lib/dashboard.module.ts
@@ -48,11 +48,6 @@ import { ProfileComponent } from './containers/profile/profile.component';
             component: SettingsComponent,
             data: { title: 'Settings', depth: '2' },
           },
-          {
-            path: 'widgets',
-            loadChildren: '@ngx-starter-kit/widgets#WidgetsModule',
-            data: { title: 'Widgets', depth: '2', preload: false },
-          },
           {
             path: 'grid',
             loadChildren: '@ngx-starter-kit/grid#GridModule',
@@ -63,6 +58,11 @@ import { ProfileComponent } from './containers/profile/profile.component';
             loadChildren: '@ngx-starter-kit/experiments#ExperimentsModule',
             data: { title: 'Experiments', depth: 2, preload: false },
           },
+          {
+            path: 'widgets',
+            loadChildren: '@ngx-starter-kit/widgets#WidgetsModule',
+            data: { title: 'Widgets', depth: '2', preload: false },
+          },
         ],
       },
     ]),

diff --git a/libs/dashboard/tsconfig.lib.json b/libs/dashboard/tsconfig.lib.json
@@ -12,16 +12,15 @@
     "experimentalDecorators": true,
     "importHelpers": true,
     "types": [],
-    "lib": ["dom", "es2015"]
+    "lib": ["dom", "es2018"]
   },
   "angularCompilerOptions": {
     "annotateForClosureCompiler": true,
     "skipTemplateCodegen": true,
     "strictMetadataEmit": true,
     "fullTemplateTypeCheck": true,
     "strictInjectionParameters": true,
-    "flatModuleId": "AUTOGENERATED",
-    "flatModuleOutFile": "AUTOGENERATED"
+    "enableResourceInlining": true
   },
   "exclude": ["src/test.ts", "**/*.spec.ts"]
 }
diff --git a/libs/draggable/tsconfig.lib.json b/libs/draggable/tsconfig.lib.json
@@ -12,16 +12,15 @@
     "experimentalDecorators": true,
     "importHelpers": true,
     "types": [],
-    "lib": ["dom", "es2015"]
+    "lib": ["dom", "es2018"]
   },
   "angularCompilerOptions": {
     "annotateForClosureCompiler": true,
     "skipTemplateCodegen": true,
     "strictMetadataEmit": true,
     "fullTemplateTypeCheck": true,
     "strictInjectionParameters": true,
-    "flatModuleId": "AUTOGENERATED",
-    "flatModuleOutFile": "AUTOGENERATED"
+    "enableResourceInlining": true
   },
   "exclude": ["src/test.ts", "**/*.spec.ts"]
 }
diff --git a/libs/experiments/tsconfig.lib.json b/libs/experiments/tsconfig.lib.json
@@ -12,16 +12,15 @@
     "experimentalDecorators": true,
     "importHelpers": true,
     "types": [],
-    "lib": ["dom", "es2015"]
+    "lib": ["dom", "es2018"]
   },
   "angularCompilerOptions": {
     "annotateForClosureCompiler": true,
     "skipTemplateCodegen": true,
     "strictMetadataEmit": true,
     "fullTemplateTypeCheck": true,
     "strictInjectionParameters": true,
-    "flatModuleId": "AUTOGENERATED",
-    "flatModuleOutFile": "AUTOGENERATED"
+    "enableResourceInlining": true
   },
   "exclude": ["src/test.ts", "**/*.spec.ts"]
 }
diff --git a/libs/grid/tsconfig.lib.json b/libs/grid/tsconfig.lib.json
@@ -12,16 +12,15 @@
     "experimentalDecorators": true,
     "importHelpers": true,
     "types": [],
-    "lib": ["dom", "es2015"]
+    "lib": ["dom", "es2018"]
   },
   "angularCompilerOptions": {
     "annotateForClosureCompiler": true,
     "skipTemplateCodegen": true,
     "strictMetadataEmit": true,
     "fullTemplateTypeCheck": true,
     "strictInjectionParameters": true,
-    "flatModuleId": "AUTOGENERATED",
-    "flatModuleOutFile": "AUTOGENERATED"
+    "enableResourceInlining": true
   },
   "exclude": ["src/test.ts", "**/*.spec.ts"]
 }
diff --git a/libs/home/tsconfig.lib.json b/libs/home/tsconfig.lib.json
@@ -12,16 +12,15 @@
     "experimentalDecorators": true,
     "importHelpers": true,
     "types": [],
-    "lib": ["dom", "es2015"]
+    "lib": ["dom", "es2018"]
   },
   "angularCompilerOptions": {
     "annotateForClosureCompiler": true,
     "skipTemplateCodegen": true,
     "strictMetadataEmit": true,
     "fullTemplateTypeCheck": true,
     "strictInjectionParameters": true,
-    "flatModuleId": "AUTOGENERATED",
-    "flatModuleOutFile": "AUTOGENERATED"
+    "enableResourceInlining": true
   },
   "exclude": ["src/test.ts", "**/*.spec.ts"]
 }
diff --git a/libs/image-comparison/tsconfig.lib.json b/libs/image-comparison/tsconfig.lib.json
@@ -12,16 +12,15 @@
     "experimentalDecorators": true,
     "importHelpers": true,
     "types": [],
-    "lib": ["dom", "es2015"]
+    "lib": ["dom", "es2018"]
   },
   "angularCompilerOptions": {
     "annotateForClosureCompiler": true,
     "skipTemplateCodegen": true,
     "strictMetadataEmit": true,
     "fullTemplateTypeCheck": true,
     "strictInjectionParameters": true,
-    "flatModuleId": "AUTOGENERATED",
-    "flatModuleOutFile": "AUTOGENERATED"
+    "enableResourceInlining": true
   },
   "exclude": ["src/test.ts", "**/*.spec.ts"]
 }
diff --git a/libs/json-diff/tsconfig.lib.json b/libs/json-diff/tsconfig.lib.json
@@ -12,16 +12,15 @@
     "experimentalDecorators": true,
     "importHelpers": true,
     "types": [],
-    "lib": ["dom", "es2015"]
+    "lib": ["dom", "es2018"]
   },
   "angularCompilerOptions": {
     "annotateForClosureCompiler": true,
     "skipTemplateCodegen": true,
     "strictMetadataEmit": true,
     "fullTemplateTypeCheck": true,
     "strictInjectionParameters": true,
-    "flatModuleId": "AUTOGENERATED",
-    "flatModuleOutFile": "AUTOGENERATED"
+    "enableResourceInlining": true
   },
   "exclude": ["src/test.ts", "**/*.spec.ts"]
 }
diff --git a/libs/led/tsconfig.lib.json b/libs/led/tsconfig.lib.json
@@ -12,16 +12,15 @@
     "experimentalDecorators": true,
     "importHelpers": true,
     "types": [],
-    "lib": ["dom", "es2015"]
+    "lib": ["dom", "es2018"]
   },
   "angularCompilerOptions": {
     "annotateForClosureCompiler": true,
     "skipTemplateCodegen": true,
     "strictMetadataEmit": true,
     "fullTemplateTypeCheck": true,
     "strictInjectionParameters": true,
-    "flatModuleId": "AUTOGENERATED",
-    "flatModuleOutFile": "AUTOGENERATED"
+    "enableResourceInlining": true
   },
   "exclude": ["src/test.ts", "**/*.spec.ts"]
 }