fix(actions): fix github actions workflow

xmlking · Sep 8, 2019 · f91fdcf · f91fdcf
1 parent b307a06
commit f91fdcf
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 6 deletions.
diff --git a/.github/workflows/api-push.yml b/.github/workflows/api-push.yml
@@ -27,14 +27,15 @@ jobs:
           NPM_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
       - name: Upload coverage to Codecov
         run: bash <(curl -s https://codecov.io/bash)
-          -F api-unittests
+          -F unittests
           -n codecov-ngx-api
           -f ./coverage/apps/api/coverage-final.json
-          -B ${{ github.head_ref }}
-          -C ${{ github.event.after }}
-          -P ${{ github.event.number }}
+          -B "${GITHUB_REF//refs\/heads\//}"
+          -T "${GITHUB_REF//refs\/tags\//}"
+          -C "${GITHUB_SHA}"
           -Z || echo 'Codecov upload failed'
         env:
           CI: true
           CODECOV_ENV: github-action
           CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+          CODECOV_PR: ${{ github.event.number }}
diff --git a/.github/workflows/push.yml b/.github/workflows/push.yml
@@ -10,8 +10,24 @@ jobs:
         uses: actions/setup-node@v1
         with:
           node-version: 12.x
+      # - name: Setup Angular CLI
+      #   run: yarn global add @angular/cli
+      #   env:
+      #     NPM_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
+      - name: Install Dependencies
+        run: yarn install
+        env:
+          NPM_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
+      - name: Linting
+        run: yarn ng lint ngx-utils
+        env:
+          NPM_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
+      - name: Testing
+        run: yarn ng test ngx-utils
+        env:
+          NPM_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
       - name: Upload coverage to Codecov
-        run: echo
+        run: bash <(curl -s https://codecov.io/bash)
           -F unittests
           -n codecov-ngx
           -f ./coverage/libs/ngx-utils/coverage-final.json

diff --git a/libs/ngx-utils/src/lib/directives/mask/mask.directive.spec.ts b/libs/ngx-utils/src/lib/directives/mask/mask.directive.spec.ts
@@ -1,8 +1,14 @@
+import { ElementRef } from '@angular/core';
 import { MaskDirective } from './mask.directive';
+export class MockElementRef extends ElementRef {
+  constructor() {
+    super(null);
+  }
+}
 
 describe('MaskDirective', () => {
   it('should create an instance', () => {
-    const directive = new MaskDirective();
+    const directive = new MaskDirective(new MockElementRef());
     expect(directive).toBeTruthy();
   });
 });