Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet package has incorrect reference to netlib.Dns #103

Closed
pergardebrink opened this issue Aug 31, 2019 · 3 comments
Closed

NuGet package has incorrect reference to netlib.Dns #103

pergardebrink opened this issue Aug 31, 2019 · 3 comments
Assignees
Labels

Comments

@pergardebrink
Copy link

I had some warnings in Visual Studio about it having conflicts about netlib.Dns when adding the jabber-net package.

I looked into the files inside thhe nuget package and it seems as for version 2.1.2, jabber-net.dll is referencing netlib.Dns, Version=1.1.5859.29905, Culture=neutral, PublicKeyToken=924c5b18328d6f09. But the provided netlib.Dns.dll in the NuGet package is of version netlib.Dns, Version=1.1.5859.29820, Culture=neutral, PublicKeyToken=924c5b18328d6f09

Maybe not the biggest issue since it seems to be able to resolve it correctly anyways.

@ForNeVeR ForNeVeR self-assigned this Sep 1, 2019
@ForNeVeR
Copy link
Member

Yeah, you're right, thanks for noticing.

For now, I definitely don't want to invest more time into 2.x version, and the issue is already fixed in the preview packages for 3.0.

@pergardebrink
Copy link
Author

Yes, that makes perfect sense ofc!

Btw, are there any plans for merging the netstandard pull request I saw you had also? At some point later I would like to target NET Core, but that could take a while. Is there anything I could do to help out?

@ForNeVeR
Copy link
Member

In previous years I was (as pretty much everyone else) very confused about .NET Core & .NET Standard thing, that's why you could possibly find traces of all the things in this repo: .NET Core migration plans, .NET Standard migration plans, maybe even a project.json or two. Now I (as pretty much everyone else?) have the stuff sorted out in my mind, and may proceed with performing the port.

(It should also be much easier with a modern .NET Standard — like, 2.0, and not that ol' good 1.3)

Honestly, I had prioritized tasks such as #95 more (because deadlock seems like a serious issue), but it's not very easy to fix, and may take me another year or two… 😿

But if you're interested in having a .NET Standard port of this library, I guess I may raise the priority on it. It looks like PR #84 should have only some minor compilation issues. If possible, could you please take a look at them? I am pretty busy these days, and don't think I'd be able to take a look at this PR this month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants