New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config autosave #767

Closed
xmrig opened this Issue Sep 30, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@xmrig
Owner

xmrig commented Sep 30, 2018

In version 2.8 default behavior for CPU miner changed, if miner use automatic threads configuration and config file, miner will override config file with suggested settings in advanced format for easy tuning.

To restore old behavior should set config option "autosave": false,, same option also added to GPU miners, but GPU miners was override config by default.

@xmrig xmrig added the enhancement label Sep 30, 2018

@xmrig xmrig added this to the v2.8 milestone Sep 30, 2018

@LearnMiner

This comment has been minimized.

Show comment
Hide comment
@LearnMiner

LearnMiner Sep 30, 2018

you should make 1 exe with cpu and gpu

LearnMiner commented Sep 30, 2018

you should make 1 exe with cpu and gpu

@xmrig

This comment has been minimized.

Show comment
Hide comment
@xmrig

xmrig Sep 30, 2018

Owner

I will probably add OpenCL part to CPU miner in v2.9, OpenCL now not adds any additional external dependency on compile and runtime also not restrict compiler version. CUDA is much more complicated thing.
Thank you.

Owner

xmrig commented Sep 30, 2018

I will probably add OpenCL part to CPU miner in v2.9, OpenCL now not adds any additional external dependency on compile and runtime also not restrict compiler version. CUDA is much more complicated thing.
Thank you.

@LearnMiner

This comment has been minimized.

Show comment
Hide comment
@LearnMiner

LearnMiner Sep 30, 2018

then will work cpu and amd in same exe?

Nice

LearnMiner commented Sep 30, 2018

then will work cpu and amd in same exe?

Nice

@2010phenix

This comment has been minimized.

Show comment
Hide comment
@2010phenix

2010phenix Sep 30, 2018

@LearnMiner what for this monster need? who want combo monster already used xmr-stack.
am always think that xmrig used because they at first compact and only at second have few nice futures....

2010phenix commented Sep 30, 2018

@LearnMiner what for this monster need? who want combo monster already used xmr-stack.
am always think that xmrig used because they at first compact and only at second have few nice futures....

@xmrig

This comment has been minimized.

Show comment
Hide comment
@xmrig

xmrig Oct 1, 2018

Owner

@2010phenix I don't think OpenCL part will make a monster.

Positive changes

  1. It's optional, OpenCL can disabled on compile time.
  2. OpenCL not add any external dependency, all required headers included to source tree, no need install AMD SDK or any other SDK.
  3. OpenCL loaded in runtime, so if it unavailable it just will be disabled, no crash due missing libraries.
  4. CPU mining code is already included to AMD miner and a lot of other code shared between miners.
  5. Command line options is ready to use together without changes.

xmr-stak required AMD APP SDK to build from source (2), and hard depends of OpenCL in runtime (3).

Negative changes

  1. Config will need change, because both CPU and OpenCL threads now use same name threads in config.
  2. Binary size will be increased, but we already lose this war since OpenSSL support added.
Owner

xmrig commented Oct 1, 2018

@2010phenix I don't think OpenCL part will make a monster.

Positive changes

  1. It's optional, OpenCL can disabled on compile time.
  2. OpenCL not add any external dependency, all required headers included to source tree, no need install AMD SDK or any other SDK.
  3. OpenCL loaded in runtime, so if it unavailable it just will be disabled, no crash due missing libraries.
  4. CPU mining code is already included to AMD miner and a lot of other code shared between miners.
  5. Command line options is ready to use together without changes.

xmr-stak required AMD APP SDK to build from source (2), and hard depends of OpenCL in runtime (3).

Negative changes

  1. Config will need change, because both CPU and OpenCL threads now use same name threads in config.
  2. Binary size will be increased, but we already lose this war since OpenSSL support added.
@2010phenix

This comment has been minimized.

Show comment
Hide comment
@2010phenix

2010phenix Oct 1, 2018

@2010phenix I don't think OpenCL part will make a monster.

@xmrig am not about code... only size ....

2010phenix commented Oct 1, 2018

@2010phenix I don't think OpenCL part will make a monster.

@xmrig am not about code... only size ....

@xmrig xmrig closed this Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment