Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flaky Test #772

Closed
insipx opened this issue May 22, 2024 · 0 comments · Fixed by #835
Closed

Fix Flaky Test #772

insipx opened this issue May 22, 2024 · 0 comments · Fixed by #835
Labels
enhancement New feature or request

Comments

@insipx
Copy link
Contributor

insipx commented May 22, 2024

Is your feature request related to a problem?

async fn test_conversation_streaming() {

Test is flaking b/c the streamed messages are arriving too slow to one end of the stream. Calls to tokio::sleep are supposed to give time for messages to arrive but depending on architecture/system speed this varies.

Describe the solution to the problem

It would be great to use async-barrier for these tests in order to guarantee sync points and avoid flakiness

Describe the uses cases for the feature

No response

Additional details

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant