Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use special character like # or | on COMMENT #60

Closed
kukigai opened this issue Sep 16, 2021 · 2 comments
Closed

Cannot use special character like # or | on COMMENT #60

kukigai opened this issue Sep 16, 2021 · 2 comments

Comments

@kukigai
Copy link

kukigai commented Sep 16, 2021

Describe the bug
Cannot use special character like # or | on COMMENT

To Reproduce
Try to parse

ddl = """
CREATE EXTERNAL TABLE test (
job_id STRING NULL COMMENT 'test'
)
STORED AS PARQUET LOCATION 'hdfs://test'
"""
from simple_ddl_parser import DDLParser
parse_results = DDLParser(ddl).run(output_mode="hql")

Expected behavior
Should get json result but got empty.

@xnuinside
Copy link
Owner

xnuinside commented Sep 16, 2021

@kukigai I added test case for special characters here https://github.com/xnuinside/simple-ddl-parser/blob/main/tests/test_hql_output_mode.py#L1639 & released version 0.19.5 https://pypi.org/project/simple-ddl-parser/ with fix. Feel free to open new issue if needed. And thanks for the report!

@kukigai
Copy link
Author

kukigai commented Sep 16, 2021

Thanks for the quick fix but found a new issue. #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants