Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question mark in COMMENT is not handled #64

Closed
kukigai opened this issue Sep 16, 2021 · 1 comment
Closed

Question mark in COMMENT is not handled #64

kukigai opened this issue Sep 16, 2021 · 1 comment

Comments

@kukigai
Copy link

kukigai commented Sep 16, 2021

Describe the bug
Question mark in COMMENT is not handled

To Reproduce
ddl = """
CREATE EXTERNAL TABLE test (
job_id STRING COMMENT 'test?'
)
STORED AS PARQUET LOCATION 'hdfs://test'
"""
from simple_ddl_parser import DDLParser
parse_results = DDLParser(ddl).run(output_mode="hql")

Expected behavior
Response should not be empty.

@xnuinside
Copy link
Owner

xnuinside commented Sep 17, 2021

@kukigai fixed in 0.19.6, version is released, '?' was added to the test - https://github.com/xnuinside/simple-ddl-parser/blob/main/tests/test_hql_output_mode.py#L1609. Feel free to open new issue if needed anything more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants