Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The documentation statement explaining the shared option is contradicting with itself #29

Open
omnir95 opened this issue May 6, 2021 · 1 comment

Comments

@omnir95
Copy link

omnir95 commented May 6, 2021

The following paragraph in the documentation is contradicting with itself:

shared (default False) – If True, a shared lock is taken. Any number of sessions can hold a shared lock; if another session attempts to take an exclusive lock, it will wait until all shared locks are released; if a session is holding a shared lock, it will block attempts to take a shared lock. If False (the default), an exclusive lock is taken.

The bold parts are the contradicting parts. How can any number of sessions hold a shared lock while holding a shared lock will block the attempts to take a shared lock?

@kamilturek
Copy link

@omnir95 Yeah, I also spotted this today. It's apparently wrong. I've prepared a PR to amend that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants