Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the parameter interface for toki-method contracts #10

Open
lamchakchan opened this issue Feb 23, 2017 · 4 comments
Open

Remove the parameter interface for toki-method contracts #10

lamchakchan opened this issue Feb 23, 2017 · 4 comments

Comments

@lamchakchan
Copy link
Contributor

Context

For the toki-method-* method contract. We are passing in a context. Lets remove it since the superset of data and utilities is binded through this anyways.

@WesTyler
Copy link
Member

@lamchakchan this is a documentation-only issue, right?
Looking at routeHandler it looks like it's already using bound context instead of the param.

@lamchakchan
Copy link
Contributor Author

@WesTyler this is both a documentation and feature deprecation ticket. @dhinklexo changed the bounded context of this so is is fully featured. Which makes the context that is passed in obsolete and confusing to use since it contains only a subset of this. But the context is still passed in as a carry over. But since we aren't at 1.0, we might as well chunk it in favor of a better mechanism.

@WesTyler
Copy link
Member

Ok, just caught up with Derrick. I was missing a piece of info. This pattern is what's needing to be removed so that the method contract has no params but instead relies entirely upon the context bound here .

Is that right?

@lamchakchan
Copy link
Contributor Author

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants