This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Fix unparsable JSON #105
Merged
Fix unparsable JSON #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarryThePenguin
commented
Nov 2, 2020
| const pkg = await loadPkg(pkgPath); | ||
|
|
||
| if (pkg.xo === false && base !== null) { | ||
| return findPackage(path.join(base, '..')); |
There was a problem hiding this comment.
path.join(base, '..') was never null, so if a package.json wasn't found, findPackage('/') would be called repeatedly
BarryThePenguin
commented
Nov 2, 2020
Comment on lines
+13
to
+14
| const newBase = path.resolve(path.dirname(pkgPath), '..'); | ||
| return getPackagePath(newBase); |
There was a problem hiding this comment.
Calculates a new base path from the directory above any package.json file found.
This way, pkg-up will handle most of the directory traversal. If it finds a package.json file with pkg.xo === false it continues traversing up.
When / is reached, it returns null.
BarryThePenguin
commented
Nov 2, 2020
mocks/unparsable/package.json
Outdated
| "devDependencies": { | ||
| "xo": "*" | ||
| } | ||
| } |
There was a problem hiding this comment.
It doesn't look like it's feasible to have a test for this situation.. Based on CI
> xo --ignore='mocks/**/*'
JSONError: JSON Error in /home/travis/build/xojs/atom-linter-xo/mocks/unparsable/package.json:
1 | {
> 2 | "name": "unparsable",,,,
| ^
3 | "devDependencies": {
4 | "xo": "*"
5 | }
Unexpected token "," (0x2C) in JSON at position 25 while parsing near "...name\": \"unparsable\",,,,\n \"devDependenci..."
1 | {
> 2 | "name": "unparsable",,,,
| ^
3 | "devDependencies": {
4 | "xo": "*"
5 | }
at module.exports (/home/travis/build/xojs/atom-linter-xo/node_modules/cosmiconfig/node_modules/parse-json/index.js:29:21)
at Object.loadJson (/home/travis/build/xojs/atom-linter-xo/node_modules/cosmiconfig/dist/loaders.js:28:20)
at Explorer.loadPackageProp (/home/travis/build/xojs/atom-linter-xo/node_modules/cosmiconfig/dist/ExplorerBase.js:82:44)
at Explorer.loadFileContent (/home/travis/build/xojs/atom-linter-xo/node_modules/cosmiconfig/dist/Explorer.js:84:32)
at Explorer.createCosmiconfigResult (/home/travis/build/xojs/atom-linter-xo/node_modules/cosmiconfig/dist/Explorer.js:89:36)
at runLoad (/home/travis/build/xojs/atom-linter-xo/node_modules/cosmiconfig/dist/Explorer.js:103:33)
at async cacheWrapper (/home/travis/build/xojs/atom-linter-xo/node_modules/cosmiconfig/dist/cacheWrapper.js:16:18)
at async Promise.all (index 4)
at async Object.lintFiles (/home/travis/build/xojs/atom-linter-xo/node_modules/xo/index.js:100:23)
at async /home/travis/build/xojs/atom-linter-xo/node_modules/xo/cli-main.js:185:18
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
package.jsoncontains a syntax error,findPackage()is called repetitively, asbaseis nevernull.This uses https://github.com/sindresorhus/pkg-up, which does return
nullif apackage.jsonfile isn't foundFixes #92
IssueHunt Summary
Referenced issues
This pull request has been submitted to: