Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@typescript-eslint/no-floating-promises issue #29

Closed
keinsell opened this issue Aug 21, 2020 · 2 comments
Closed

@typescript-eslint/no-floating-promises issue #29

keinsell opened this issue Aug 21, 2020 · 2 comments

Comments

@keinsell
Copy link

keinsell commented Aug 21, 2020

I've experienced some issue when I was using xo with react package, I've used configuration from eslint-config-xo-react but it seems eslint-config-xo-typescript have a little issue with configuration.

It's line 306 at index.js

ui: Error: BaseConfig » eslint-config-xo-typescript:
ui:     Configuration for rule "@typescript-eslint/no-floating-promises" is invalid:
ui:     Value {"ignoreVoid":true,"ignoreIIFE":true} should NOT have additional properties.
ui:     at validateRuleOptions (/Users/jay/GitHub/humantic/node_modules/eslint/lib/shared/config-validator.js:132:19)
ui:     at /Users/jay/GitHub/humantic/node_modules/eslint/lib/shared/config-validator.js:187:9
ui:     at Array.forEach (<anonymous>)
ui:     at validateRules (/Users/jay/GitHub/humantic/node_modules/eslint/lib/shared/config-validator.js:184:30)
ui:     at validateConfigArray (/Users/jay/GitHub/humantic/node_modules/eslint/lib/shared/config-validator.js:312:9)
ui:     at CascadingConfigArrayFactory._finalizeConfigArray (/Users/jay/GitHub/humantic/node_modules/eslint/lib/cli-engine/cascading-config-array-factory.js:464:13)
ui:     at CascadingConfigArrayFactory.getConfigArrayForFile (/Users/jay/GitHub/humantic/node_modules/eslint/lib/cli-engine/cascading-config-array-factory.js:275:21)
ui:     at CLIEngine.isPathIgnored (/Users/jay/GitHub/humantic/node_modules/eslint/lib/cli-engine/cli-engine.js:953:18)
ui:     at /Users/jay/GitHub/humantic/node_modules/xo/index.js:48:32
ui:     at Array.filter (<anonymous>)
ui: error Command failed with exit code 1.
ui: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
@sindresorhus
Copy link
Member

You probably need to update @typescript-eslint.

@keinsell
Copy link
Author

keinsell commented Aug 21, 2020

I've reinstalled my node_modules and problem has gone. As you said, that was probably problem to @typescript-eslint but not exactly with update, maybe I had multiple instances of @typescript-eslint in monorepo and something messed up.

However, Thanks @sindresorhus for help. You're awesome <3 My issue got resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants