Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsconfig 0.9 and dot-notation #34

Closed
EdJoPaTo opened this issue Feb 25, 2021 · 1 comment
Closed

tsconfig 0.9 and dot-notation #34

EdJoPaTo opened this issue Feb 25, 2021 · 1 comment

Comments

@EdJoPaTo
Copy link

tsconfig 0.9.0 introduced noPropertyAccessFromIndexSignature which requires refactoring from foo.bar to foo['bar']. xo then errors on @typescript-eslint/dot-notation as foo['bar'] can be written as foo.bar.

The relevant tracking issue: typescript-eslint/typescript-eslint#3104
(I already saw your thumbs up on the issue)

As a temporary fix xo might disable this rule (changing it only to warn would end up in xo --fix which "fixes" it which is annoying then).
Re enable when the mentioned issue is fixed.
The alternative is to wait with the tsconfig 0.9 upgrade. (While writing this issue I think this might be the easiest way to handle this)

@sindresorhus
Copy link
Member

Finally fixed: https://github.com/typescript-eslint/typescript-eslint/releases/tag/v4.24.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants