@typescript-eslint/naming-convention: enumMember should not be in strictCamelCase

[jonahsnider]

eslint-config-xo-typescript/index.js

Line 286 in 7c1e7d2

selector: ['variable', 'function', 'classProperty', 'objectLiteralProperty', 'parameterProperty', 'classMethod', 'objectLiteralMethod', 'typeMethod', 'accessor', 'enumMember'],

enumMembers should not be in strictCamelCase.

TypeScript documentation doesn't make a specific recommendation of enum member naming, although they exclusively use StrictPascalCase and UPPER_CASE (both of which are reasonable).

[sindresorhus]

It was an intentional choice. I'm aware the TS docs use pascal-case, but it honestly makes no sense to me. Enum cases are members, and all other kinds of members are camel-case.

I think the Swift style enum casing looks the best and makes the most sense:

enum CardSuit {
	case clubs
	case diamonds
	case hearts
	case spades
}

[jonahsnider]

That seems like a weird decision to make, we aren't writing Swift, we're writing TypeScript. It's also not accurate to compare enum members to other object members. Enum values are readonly constants which have never had the same naming convention as regular variables/object members. Node.js themselves use UPPER_CASE for enum values (ex. os.constants.signals).

Also worth mentioning is that enum members are implicitly types as well as values:

enum Color {
	R, G, B
}

const value: Color.R = Color.R;

Having this rule seems like a mistake and I think most other XO users will agree. I'd recommend simply removing the enumMember naming rule entirely, instead leave it up to developers to pick a naming convention they like.

[EdJoPaTo]

Interestingly I dont seem to use enums in TypeScript (rg "enum" --glob "*.ts" -A 5).
Personally I use string unions (type Something = 'foo' | 'bar') in these cases. And I seem to use camelCase for the values there.

My other language Rust where I use enums PascalCase is used (or the linter warns about not using it)

[sindresorhus]

That seems like a weird decision to make, we aren't writing Swift, we're writing TypeScript.

TypeScript makes a ton of mistakes and weird choices by default.

Node.js themselves use UPPER_CASE for enum values (ex. os.constants.signals).

Those are not enum values though. And Node.js is not a good example of well-done APIs.

Also worth mentioning is that enum members are implicitly types as well as values:

This would be totally fine too:

const value: Color.r = Color.r;

Having this rule seems like a mistake and I think most other XO users will agree.

I think most people don't use TS enums as they're weirdly designed and also doesn't fit with JS. Most people use unions.

[sindresorhus]

That being said, I don't use TS enums, so I agree with just ignoring it in the rule: https://github.com/xojs/eslint-config-xo-typescript/releases/tag/v0.45.2