Enable @typescript-eslint/consistent-type-definitions rule

[jonahsnider]

It's been about 3 years since @typescript-eslint/consistent-type-definitions was added to this config as a disabled rule.

eslint-config-xo-typescript/index.js

Lines 211 to 215 in 79d6708

	// This rule is fine. I just don't want to deal with the churn yet. Enable this in 2023.
	// '@typescript-eslint/consistent-type-definitions': [
	// 'error',
	// 'type'
	// ],

Can we re-enable it?

The rule has an automated fixer which should make adoption easy.
I'm not sure there are any situations where you'd even need to manually make the change.

---

I'll also mention that it may be worth revisiting the decision to prefer type over interface. Historically there were performance concerns from using type instead of interface, but I'm not sure if those are still relevant now.

[sindresorhus]

Yeah, I'll enable it in the next XO version.

[fregante]

-> #63