Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow AVA helper filename convention #172

Closed
jamestalmage opened this issue Jan 1, 2017 · 2 comments
Closed

Allow AVA helper filename convention #172

jamestalmage opened this issue Jan 1, 2017 · 2 comments

Comments

@jamestalmage
Copy link
Contributor

jamestalmage commented Jan 1, 2017

I currently get the following error running the test suite for ava-files.

  fixtr/default-patterns/test/_foo-help.js:1:9
  ✖    1:9  Filename is not in kebab case. Rename it to foo-help.js  xo/filename-case

Should we allow leading underscores? Should we only allow it in the default test and fixture folders?

Note: ava-files does not use the default fixture folder (so if we only allow it for the default folders, we would need to explicitly add an exception anyways).

Ref: avajs/ava-files@3f2a63a

@sindresorhus
Copy link
Member

sindresorhus commented Jan 5, 2017

I think we should allow it anywhere. It's common convention in many ecosystems.

This issue would be better opened on eslint-plugin-unicorn though.

@sindresorhus sindresorhus changed the title Allow AVA helper filename convention. Allow AVA helper filename convention Jan 5, 2017
@sindresorhus
Copy link
Member

Moved to sindresorhus/eslint-plugin-unicorn#79.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants