-
-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically ignore directories/files in .gitignore #27
Comments
+1 |
I think this could be useful. Is there ever a scenario where you would want to lint |
Amen. I really dislike duplicating my If XO automatically ignores .gitignore patterns, it will keep our configuration DRY and make projects easier to maintain. |
I like this idea too, looks totally reasonable. |
Yup, totally, just needs someone willing to do the work. I haven't had time yet. |
Possibly helpful: https://github.com/jonschlinkert/parse-gitignore |
$40 bounty because ❤️. xoxo |
I can help with this. |
Oops I didn't pay attention that @juanj was also fixing this. :D well... I made my PR anyway |
Thanks for the bounty @sholladay. You can award it to @juanj :) |
Thanks @juanj for your efforts. I'm very happy that this issue was solved. I just want to vent that I don't think this was completely fair play. Except for the '''nested .gitignores''' and '''cwd option''' requests, my single commit which was made on Sept 30 already had the same code and tests as @juanj 's 17 commits which spanned from Sept 30 to Oct 11. I believe that at least a mention by @juanj is in order about copying the tests from my PR. But again, this isn't really about ownership of code nor about distribution of bounties as it is about collaboration. I'm just happy this got solved anyway. Now I'm ready to take all your arrows on me like this :) lol and cheers |
Hi @shadiakiki1986, I hear you. And I appreciate your work. The purpose of my bounty was to contribute to the community and to encourage people like you to do so, too. I don't want that message to get lost. I will try to find a way to reward you, too. It may take me a few days to get around to it. Likely I will cc you on another issue and award a higher bounty for that then I otherwise would have, while making it obvious it should go to you. Again, thanks for your time. |
Hey @shadiakiki1986 sorry if I didn't give you credit for that. But I don't copy your test's I just make a copy of one of the existing test and adapt it to test what we need. In the end it result in a very similar test. |
To avoid all those pesky babel and electron build dirs.
The text was updated successfully, but these errors were encountered: