Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding Typescript settings from an extended config #438

Closed
Richienb opened this issue Mar 2, 2020 · 3 comments · Fixed by #442
Closed

Allow overriding Typescript settings from an extended config #438

Richienb opened this issue Mar 2, 2020 · 3 comments · Fixed by #442

Comments

@Richienb
Copy link
Contributor

Richienb commented Mar 2, 2020 •
edited

At the moment, if a @typescript-eslint rule is specified in a config that would be extended from, xo automatically overrides it with the default xo-typescript rules. It should be the other way round.
@sindresorhus
Copy link
Member

// @pvdlg

@pvdlg
Copy link
Contributor

pvdlg commented Mar 8, 2020

@Richienb can you provide a reproducible example?

@Richienb
Copy link
Contributor Author

Richienb commented Mar 8, 2020

@pvdlg https://github.com/Richienb/xo-typescript-extends

@pvdlg pvdlg mentioned this issue Mar 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add xo-typescript and prettier/@typescript-eslint before user extends xojs/xo
3 participants
@sindresorhus @pvdlg @Richienb