Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable import/named on JS-only projects #576

Closed
fregante opened this issue Jul 12, 2021 · 1 comment · Fixed by #601
Closed

Enable import/named on JS-only projects #576

fregante opened this issue Jul 12, 2021 · 1 comment · Fixed by #601
Labels
enhancement good for beginner help wanted

Comments

@fregante
Copy link
Member

xo/config/plugins.cjs

Lines 203 to 205 in f81e933

// Disabled as it doesn't work with TypeScript.
// This issue and some others: https://github.com/benmosher/eslint-plugin-import/issues/1341
// 'import/named': 'error',

I think import/named isn't useful on TS projects because TS already verifies the imports. Can this rule be enabled on JS files only?
fregante referenced this issue Jul 12, 2021
@sindresorhus
Improve ESM compatibility
211f295 
Fixes #386
@sindresorhus
Copy link
Member

We simplify need to disable it here:

xo/lib/options-manager.js

Line 407 in f81e933

if (options.ts) {

@1000ch 1000ch mentioned this issue Sep 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good for beginner help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable import/named rule for JavaScript 1000ch/xo
2 participants
@sindresorhus @fregante