Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to run on Windows if package.json present #57

Closed
dandv opened this issue Aug 10, 2015 · 5 comments
Closed

Failure to run on Windows if package.json present #57

dandv opened this issue Aug 10, 2015 · 5 comments
Labels

Comments

@dandv
Copy link
Contributor

dandv commented Aug 10, 2015

If there's a package.json in the directory node_modules\.bin\chimp --watch is run from, Chimp fails with this message:

[chimp] stderr: 'C:\Program' is not recognized as an internal or external command,
operable program or batch file.

npm install error { [Error: Command failed: C:\Windows\system32\cmd.exe /s /c "C:\Program Files\nodejs\npm install"
'C:\Program' is not recognized as an internal or external command,
operable program or batch file.
]
  killed: false,
  code: 1,
  signal: null,
  cmd: 'C:\\Windows\\system32\\cmd.exe /s /c "C:\\Program Files\\nodejs\\npm install"' }
Error in chimp init { [Error: Command failed: C:\Windows\system32\cmd.exe /s /c "C:\Program Files\nodejs\npm install"
'C:\Program' is not recognized as an internal or external command,
operable program or batch file.
]
  killed: false,
  code: 1,
  signal: null,
  cmd: 'C:\\Windows\\system32\\cmd.exe /s /c "C:\\Program Files\\nodejs\\npm install"' }

To reproduce, save the file below as package.json in some directory, then run npm install and node_modules\.bin\chimp --watch:

{
  "name": "chimp-bug",
  "devDependencies": {
    "chimp": "^0.14.0"
  }
}
@ghost ghost added the bug label Aug 10, 2015
@sudsy
Copy link
Contributor

sudsy commented Sep 7, 2015

I was able to partially resolve this on my windows box with a change of the following line in chimp.js:

  this.exec(npmPath + ' install', function (error, stdout, stderr) {

to

  this.exec('"' + npmPath + '" install', function (error, stdout, stderr) {

However I hit a node_gyp build error (problem with my windows box) in trying to test the solution so I couldn't verify that the solution really worked.

@samhatoum
Copy link
Member

thanks for the headsup @sudsy

I've just updated chimp to work with the node 0.4.1 and it fixed a node_gyp issue I was having. That might sort it for you too. Please try 0.15.x when you get a moment

@toas1
Copy link

toas1 commented Oct 8, 2015

Hi!

We're having the same issue with the latest version of Chimp. Any news on fixing this?

@samhatoum
Copy link
Member

We haven't worked on it yet. Hoping to get it out in the next release

@ghost ghost self-assigned this Oct 9, 2015
@ghost ghost closed this as completed in bd839ba Oct 9, 2015
@ghost
Copy link

ghost commented Oct 9, 2015

This is now fixed with 0.17.2.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants