refactor(vox): expand VIRTUALENV_HOME '~' #4972
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgerak
force-pushed
the
4608-expand-home
branch
from
43045db
to
3015f4c
Compare
jnoortheen
approved these changes
Oct 20, 2022
|
Not sure why tests fail on Windows (and I don't have an env to test on). Can't be sure whether it's the tests that should be refactored or if there's an actual issue with the implementation - all paths I see ultimately call |
|
@vgerak please check https://xon.sh/devguide.html#cross-platform-testing and the tmate action. |
jnoortheen
force-pushed
the
4608-expand-home
branch
from
3015f4c
to
a36b51b
Compare
jnoortheen
force-pushed
the
4608-expand-home
branch
from
a36b51b
to
223b699
Compare
|
As the venv extension is now moved to its own repo. I am closing it here. Please reopen it here https://github.com/xonsh/xontrib-vox . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes xonsh/xontrib-vox#2
For community
⬇️ Please click the 👍 reaction instead of leaving a
+1or 👍 comment