-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows 10: Response Code 400 #27
Comments
@csisoap Thank you so much, I managed to download the subtitles of the TV series "Fear the Walking Dead" by renameing the link to https://www.hulu.com/series/walking-dead-6b075a0b-3d97-42a8-b2f1-c1d698d64d53 and used the new link and it worked (seems that the name works only if it has two words, "rick-and-morty" to work you need to rename it to "and-morty"). If the TV series has one word only like "futurama" the link will not work, adding "-" before the name will make the link works like "-futurama". https://www.hulu.com/series/futurama-85bf4cc1-cd8b-4469-ad87-7289217a0b74 https://www.hulu.com/series/-futurama-85bf4cc1-cd8b-4469-ad87-7289217a0b74 |
Woah, this is a weird thing that's happening. I'll add a bug tag to this and see if it's happening with all the series or just some handful of them. |
@Xonshiz The script does not work with the links of the movies like https://www.hulu.com/movie/terminator-dark-fate-3be9a47d-4a50-447a-980a-e5cae615f522 it works only when i replace "/movie/" and the name of the movie with "/watch/". https://www.hulu.com/watch/3be9a47d-4a50-447a-980a-e5cae615f522 and the name of the subtitle file of the movie become "No Name Found - S01E01 [en Sub].srt" |
Yes, that "/watch" thing is a known "issue" or "thing" however you term it. It was me being lazy to not add one more entry of check after I had checked in a general code that worked for both. It's just an extra step haha. I'll patch it up in next fix. But, what I'm more curious about is that the script is working with just "2 words"... like that walking dead link. That needs to be looked into. I'll see if I can muster up some time to look into this. Ah No Name found thing.... Didn't know about it. Seems like Hulu has changed some things again. I'll need to update this. |
@Xonshiz It seems to be about the "-" more than the title has two words, like the TV series "Malcolm in the Middle" could work with only "-middle". https://www.hulu.com/series/malcolm-in-the-middle-ca1ac46e-9883-4125-a6e8-97efce9a2bf5 https://www.hulu.com/series/-middle-ca1ac46e-9883-4125-a6e8-97efce9a2bf5 |
@Xonshiz i think instead of grabbing the first two, try to grab five words from the last. |
See.. that's the thing... I don't remember putting any code that deletes/grabs any specific set of words. It should take all and send to HULU APIs. That's why I'll need to see what is happening, where and why. |
Thanks for the response. Your link was recognized, but I ran into a new issue:
Which also doesn't produce a log, but it seems like it should work? |
@clayton-grey You could download the subtitles of the TV show "The Great North" in "srt" format. |
That subtitle thing is another issue. Could you open a separate bug for that. Helps in checking what all things I need to fix. Also, @Essam3111 good that you were helping, but, I'd suggest that you do not share an actual subtitle file over here. I think your comment was removed and I really don't want this repo getting nuked on some BS DMCA notice. |
@Xonshiz I deleted the comment by myself for the same reason. |
Hhahah I see... good, thanks :D |
@Xonshiz Just a simple observation, when I try to download the subtitles in "ttml" format or "smi" format for any TV show, the script download only the first episode, but when I go to the folder of the downloaded subtitles no subtitles are actually downloaded and the folder is empty, Hulu subtitles in "ttml" do not work correctly with Subtitle Edit, Subtitle Edit displays the time wrongly (nothing wrong with the subtitles themselves), and Hulu subtitles in "smi" format are encrypted. |
Ah, I see. Could you please open a new bug report for that and also mention some URLs where you can see this issue. |
I could, but I use VTT, so it saves me conversion steps, and it should be possible to get from their servers. I'll open a new ticket for this. |
@clayton-grey This is just a workaround, until the script got fixed you could use it for downloading the subtitles in "webvtt" format, in config file add 'webvtt'. In In
with
In
with
|
@Xonshiz This might help you in figuring out a solution for the problem of the non working links for the TV shows like https://www.hulu.com/series/fear-the-walking-dead-6b075a0b-3d97-42a8-b2f1-c1d698d64d53 and https://www.hulu.com/series/futurama-85bf4cc1-cd8b-4469-ad87-7289217a0b74 when i compared between the "Hulusubs_dl_Error_Log" for the non working link for the TV show "Fear the walking dead" https://www.hulu.com/series/fear-the-walking-dead-6b075a0b-3d97-42a8-b2f1-c1d698d64d53
and the working one for the TV show "Fear the walking dead" https://www.hulu.com/series/walking-dead-6b075a0b-3d97-42a8-b2f1-c1d698d64d53
I found that with the non working link for the TV show "Fear the walking dead" we get the wrong link (It has the words "walking-dead-" which they should not be in the link) and in the working link for the TV show "Fear the walking dead" we get the correct link and when i compared between the "Hulusubs_dl_Error_Log" for the non working link for the TV show "Futurama" https://www.hulu.com/series/futurama-85bf4cc1-cd8b-4469-ad87-7289217a0b74
and the working one for the TV show "Futurama" https://www.hulu.com/series/-futurama-85bf4cc1-cd8b-4469-ad87-7289217a0b74
I found that with the non working link for the TV show "Futurama" we get the wrong link (the links is missing "85bf4cc1-") and in the working link for the TV show "Futurama" we get the correct link |
@Xonshiz I found out why the link works only if it has two words, this regular expression removes one word https://www.hulu.com/series/castle-rock-b11816c9-9e35-44f3-bf04-220b1d12f770 https://github.com/Xonshiz/Hulusubs_dl/blob/master/hulusubs_dl/hulu.py#L86 https://regex101.com/r/48hdPs/1 and this line removes another word https://github.com/Xonshiz/Hulusubs_dl/blob/master/hulusubs_dl/hulu.py#L89 and we get the correct link this is the correct regular expression for selecting all the words
|
Nice sleuthing. |
Holy crap... You've literally fixed it all. hahahaha Thank you so much @Essam3111 . EDIT: Oh I think I just remembered why I used that regex. Didn't see if failing this badly :( |
- Should close #27 - Added fix for downloading subtitles for movie urls.
@Xonshiz Thank you so much, I tested the dev branch and everything is working great until now, just one more problem still needs to be fixed, the movie subtitle file name is "No Name Found - S01E01 [en Sub]", here is the Hulusubs_dl_Error_Log for the movie https://www.hulu.com/movie/terminator-dark-fate-3be9a47d-4a50-447a-980a-e5cae615f522 |
Yep, the thing is, I don't have the JSON that's returned. So, what I'm guessing is that for "movie", they have a different JSON getting back and for a show video, they have different JSON getting back. Thanks for sharing the verbose dump, this should have the JSON, maybe I can work my way out of that one. |
@Xonshiz Just a very minor problem with the name of the downloaded subtitle file for the movie, the number of the season added to the name of the subtitle file and a season folder created like. C:\Hulusubs_dl\Terminator - Dark Fate\01\Terminator - Dark Fate - S01E01 [en Sub].srt https://www.hulu.com/movie/terminator-dark-fate-3be9a47d-4a50-447a-980a-e5cae615f522 |
Ah, got it. Could you open a separate bug for that? It's cased via different functionality and this issue serves purpose for 400 error. |
I was having trouble with the executable on OSX (I recently migrated to a different computer, so the setup I had working before isn't handy anymore), so I tried the Windows version, which seemed to work more as described:
OS: Windows 10
Version: EXE
Here's the output:
The text was updated successfully, but these errors were encountered: