Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .NET Framework projects #2

Open
slang25 opened this issue Jul 5, 2021 · 0 comments
Open

Support .NET Framework projects #2

slang25 opened this issue Jul 5, 2021 · 0 comments
Labels
enhancement New feature or request PR welcome You can help contribute to this issue

Comments

@slang25
Copy link
Contributor

slang25 commented Jul 5, 2021

馃ぎ I know right. Actually, issue #1 would remove the need for this, as I could handle the build elsewhere and just pass the binlog output.

That said, I don't think it would be adding much complexity to have a simple heuristic to check the project file and decide to run dotnet, or instead msbuild. This does feel like it's straying a bit into the buildalyzer territory of having lots of smarts baked in.

Here's how buildalyzer decides where to find msbuild for reference: https://github.com/daveaglick/Buildalyzer/blob/main/src/Buildalyzer/Environment/EnvironmentFactory.cs#L162

@xoofx xoofx added enhancement New feature or request PR welcome You can help contribute to this issue labels Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR welcome You can help contribute to this issue
Projects
None yet
Development

No branches or pull requests

2 participants