Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xoopsMultiMailer (PHPMailer) vars not being set correctly by xoopsMailer #102

Closed
zyspec opened this issue May 9, 2016 · 1 comment
Closed
Labels

Comments

@zyspec
Copy link
Contributor

zyspec commented May 9, 2016

There were changes between 2.5.7 and 2.5.8 that cause some of the XoopsMultiMailer class vars not to be set correctly - which is different than in XOOPS 2.5.7.

It appears that there were some changes to 'fix' some vars by changing them to camelCase however it has created some issues between variable naming in xoopsMailer and xoopsMultiMailer (PHPMailer). For example in xoopsMailer the var is body ($this->body) but in PHPMailer it is Body ($this->Body) - this causes the body of the message to not be set correctly.

Other variables need to be checked too - for example: Subject, Charset, Encoding, Sender and FromName... There may be others but I wanted to flag this as quickly as possible so 2.5.8 doesn't go FINAL before someone can look at this.

See the xoopsMailer->sendMail() method for example where the variable case needs to evaluated.

@geekwright geekwright added the bug label May 9, 2016
@mambax7
Copy link
Collaborator

mambax7 commented May 9, 2016

Since it was most probably my fault, I'll take care of it...
Thanks, Jim, for reporting it...

mambax7 added a commit to mambax7/XoopsCore25 that referenced this issue May 10, 2016
@mambax7 mambax7 mentioned this issue May 10, 2016
MekDrop pushed a commit to OldXoopsLibraries/xoops-form that referenced this issue Feb 15, 2018
MekDrop pushed a commit to OldXoopsLibraries/xoops-form that referenced this issue Feb 16, 2018
MekDrop pushed a commit to OldXoopsLibraries/xoops-form that referenced this issue Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants