Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinview shows "xx pasted from yy" notification on entering pin #54

Closed
leijdekkers opened this issue Sep 23, 2020 · 9 comments
Closed

Pinview shows "xx pasted from yy" notification on entering pin #54

leijdekkers opened this issue Sep 23, 2020 · 9 comments
Assignees

Comments

@leijdekkers
Copy link

Since iOS 14 the SVPinview shows a "xxx pasted from yyy" notification whenever i enter text/number into a SVPinView. Looks like the UITextField needs to be modified and disable clipboard actions. Or can this be done already? If so how?

@jpauljm
Copy link

jpauljm commented Sep 29, 2020

I'd try a PR but it appears the owner doesn't accept PR since 2018. So, this is the solution:
CustomSVPinView.swift -> Remove (string == UIPasteboard.general.string) in line 454
If you're using pods, fork it and use it as a private pod. Otherwise, manually insert it into your project.

Cheers

@xornorik
Copy link
Owner

@leijdekkers Many thanks for reporting this! Apologies for the delay in response. Will put out a release with the changes suggested by @aKANJx.

@aKANJx
Thank you for the solution! Will add your change and put out a release today.

I'd try a PR but it appears the owner doesn't accept PR since 2018.

Not true. I've not merged some of the PR's due to certain reasons, but I have merged in most of the PR's (the last release was a PR - #42). I suppose I should resolve all of them to avoid confusion 🙂.
Thanks again for the solution! Appreciate it!

@xornorik xornorik self-assigned this Sep 29, 2020
@leijdekkers
Copy link
Author

Thanks! It is a bit of a showstopper right now getting all these notifications when you enter a pincode! Appreciate the effort.

@leijdekkers
Copy link
Author

When will you release an updated version fixing this issue?

@xornorik
Copy link
Owner

@leijdekkers
Just did on CocoaPods.
Carthage is giving me some troubles; it appears there have been some heavy changes for Xcode 12 - more here

If you're using CocoaPods, could you confirm if you're still getting the notification?

@xornorik
Copy link
Owner

@leijdekkers Are you using CocoaPods or Carthage?

@leijdekkers
Copy link
Author

Just tested it and all good! No more notifications! Thanks a lot!

@xornorik
Copy link
Owner

Thant's great! Thanks for the confirmation. 🙂

@jpauljm
Copy link

jpauljm commented Oct 5, 2020

Thanks, @xornorik! Sorry, I misinterpreted the PRs. I appreciate all effort you're doing creating and maintaining this useful repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants