Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domoticz lights refactoring #1588

Merged
merged 2 commits into from
Mar 1, 2019
Merged

Domoticz lights refactoring #1588

merged 2 commits into from
Mar 1, 2019

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Feb 27, 2019

  • refactor domoticz lights handler into separate function
  • less debugging strings. show that domoticz had parsed values in a single line. -480 bytes off the firmware. (travis03 dev:631248 domoticz/update:630768)
  • fix relay getter to return signed value, as intended

cc @karmacoma92
please check if it fixes the problem you are experiencing (from gitter https://gitter.im/tinkerman-cat/espurna?at=5c7651cd8a7def0752e40812)

@mcspr mcspr added this to the 1.13.6 milestone Feb 27, 2019
@karmacoma92
Copy link

Hi Max,

Tested and working, something weird appeared after first reboot, in the general tab instead of appearing Temperature#0
Humidity#0
appeared something like NaN#0 repeated a number of times, ...

it is working now Thanks a lot!
Oscar

@mcspr
Copy link
Collaborator Author

mcspr commented Feb 28, 2019

@karmacoma92 thank you.
about the second one - no idea right now. this function generates the string, but i cannot get it to output NaN with strings / numbers / nulls :/
if you'll have time, do you mind tracing websocket sensor data ({magnitudes: type:[...], ...} ) that is sent to the webui? if you are using chrome or safari, see /ws in the network tab of web developer tools (ctrl / cmd + shift + i)

@karmacoma92
Copy link

Hi Max,
It happened only once, the first time I finally upgraded it, I have tried to reproduce it upgrading another esp01s-dht11 but it didn't happened so I don't know if makes any sense to investigate further.
Here you have a screenshot of the requested trace, (I do not see anything weird though,...)
espurna_details

I'm experiencing some other problem with a basic Sonoff which I cannot swtich on, it keeps on going back to off, but I do not know if I should open a different case....

Thanks once more
Oscar

@mcspr mcspr merged commit 3018b9f into xoseperez:dev Mar 1, 2019
@mcspr mcspr deleted the domoticz/update branch March 1, 2019 19:39
@mcspr
Copy link
Collaborator Author

mcspr commented Mar 1, 2019

ok, thanks anyways.
and btw, web inspector would only show the requests after they are made, meaning you need to have it active and then reload the page. it'll show /auth, hostname, and /ws, where /ws will have "frames" tab with websockets data. which may or may not have been broken, somehow.

I'm experiencing some other problem with a basic Sonoff which I cannot swtich on, it keeps on going back to off, but I do not know if I should open a different case...


if that is reproducible, then yes.

@karmacoma92
Copy link

I'll try reproducing it with the latest code from today but with the previous one, yes I can reproduce it....
Regarding the other issue, I was trying to reload with F5, but it was giving nothing as shown in the picture....

@karmacoma92
Copy link

I tried with a compilation with the changes form yesterday, but still the same, please tell me where to report it...
Thanks
Oscar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants