Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are sub-second pulse times possible? #159

Closed
xoseperez opened this issue Jun 26, 2017 · 5 comments
Closed

Are sub-second pulse times possible? #159

xoseperez opened this issue Jun 26, 2017 · 5 comments
Labels

Comments

@xoseperez
Copy link
Owner

Originally reported by: Stephan Winokur (Bitbucket: swinokur, GitHub: swinokur)


Hi,
Loving this firmware! One thing that would be useful to me, is the ability to have pulse times that are less than a second - I'm using relays to do "button presses" and a 1 second button press is a long time for a button to be held "down."

thanks!

@xoseperez
Copy link
Owner Author

Original comment by Lauris Ieviņš (Bitbucket: laurisievins, GitHub: Unknown):


Ticker library, which is used to time pulses, has a 1ms resolution, so technically it is possible to have shorter pulses. Problem here is that currently there is no way to specify sub-second time in web interface. The easiest way to implement this would probably be to change the value to be in milliseconds instead of seconds, but then this change has to be made backward compatible, so that after firmware upgrade pulse does not become 1000 times shorter (e.g. 1ms instead of 1s).
How short you need the pulse to be? Is 1s really too long for you?

@xoseperez
Copy link
Owner Author

The other ways would be to 1) accept decimal values in the web interface (kind of ugly but backwards compatible) or 2) have to radio buttons to specify the unit, seconds (default) or milliseconds

@xoseperez
Copy link
Owner Author

Original comment by Lauris Ieviņš (Bitbucket: laurisievins, GitHub: Unknown):


I have experimented with this and decimal values work just fine. Tricky thing is to validate the input in web interface. I can create a pull request with what I have so far if it is fine with you.

@xoseperez
Copy link
Owner Author

Removing milestone: 1.8.2 (automated comment)

@xoseperez
Copy link
Owner Author

Added to 1.8.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant