Sensors can determine precision of their magnitudes #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resent its magnitude types; update sensor.ino to take advantage of this knowledge; sensors BMX280 and Dallas OneWire are updated with this knowledge; tested with BME280 and Dallas DS18B20 sensors
|
LGTM. Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently espurna magnitude precisions are hard-coded in sensor.ino. For example the default temperature precision is whole integer degrees Celsius. This causes sensors such as the Dallas DS18B20 to miss 3 digits of extra precision.
This change modifies BaseSensor so that each sensor class can specify the number of decimals to represent its magnitude types. If the sensor does not override this virtual method, the default is to use the sensors.ino hard-coded values (i.e. fall back on previous method).
I also updated sensors BMX280 and Dallas OneWire are with the specified precision knowledge; tested with BME280 and Dallas DS18B20 sensors