Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core 2.6.0+ fixes #1852

Merged
merged 6 commits into from
Aug 15, 2019
Merged

Core 2.6.0+ fixes #1852

merged 6 commits into from
Aug 15, 2019

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Aug 12, 2019

  • travis04 to test build with current esp8266/Arduino master
  • lwip -> lwip2
  • small fix for gcc-9 compilation

@mcspr
Copy link
Collaborator Author

mcspr commented Aug 12, 2019

@Niek the template addition fixes build with gcc-7 & gcc-9

for tests:
~/.platformio/packages/framework-arduinoespressif8266@src-31d658a59f41540201fc3726a1394910 with checked out https://github.com/earlephilhower/Arduino/tree/gcc9.1
manually fetch https://github.com/earlephilhower/esp-quick-toolchain/releases/tag/3.0.0-gnu1 and unpack into the ~/.platformio/packages/toolchain-xtensa-91
copy ~/.platformio/packages/toolchain-xtensa/package.json and modify the version. e.g.

--- toolchain-xtensa/package.json       2019-08-13 00:02:16.052773600 +0300
+++ toolchain-xtensa-91/package.json    2019-08-13 00:01:44.126792900 +0300
@@ -3,5 +3,5 @@
     "name": "toolchain-xtensa",
     "system": "linux_x86_64",
     "url": "https://github.com/earlephilhower/esp-quick-toolchain",
-    "version": "2.40802.190218"
+    "version": "2.99999.220719"
 }

@Niek
Copy link
Contributor

Niek commented Aug 13, 2019

Nice, LWIP2 as default makes sense as well. I only seem to have some crashes on AP mode with git core, but that might be some of my own code - will investigate further.

Did you notice any difference in build size and heap usage when building with 9.1?

@mcspr
Copy link
Collaborator Author

mcspr commented Aug 15, 2019

Did you notice any difference in build size and heap usage when building with 9.1?

With the same debug POW build it is ~5.5KB less in size. Heap metric... around the same. Initial value changes though - 43296 bytes with the current toolchain and 42808 bytes with gcc-9 (ofc everything is built with the same gcc9.1 tree)

@mcspr mcspr merged commit ef153b4 into xoseperez:dev Aug 15, 2019
@mcspr mcspr deleted the travis04 branch August 15, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants