Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2166
@karmacoma92, I think this should work now.
We already buffer the data to inject '\0' at the end, but we never re-use the buffer. Instead, allocate
char buf[MQTT_MAX_PACKET_SIZE]
and place the data there until we got the full message. Static allocation, avoid dynamicchar buf[len+1]
. Default buffer size is 1024 bytes.Also avoid using strlcpy, since we already know the length (and because of weird len+1)