-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIO: fix env definitions (again) #2212
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2nd try for #2099
Resolve #2197
Move base envs to the same model as travis-{2_3_0,latest,git}:
extends = esp8266-{,latest,git}-SIZE-base
instead ofbuild_flags = ${common.build_flags_SIZE}
Additionally:
Since we
can'tdon't know how to force PIO to respect our wishes to not destroy build directory when our settings change or we add / remove files to project directory. Or, have any way of caching intermediate files that have the same source+build_flags but different env: https://community.platformio.org/t/build-cache-dir-will-not-share-object-files-between-envs/10011So, instead, adjust build script to use another script that compiles env list into a compatible
pio run
calls that will re-use environment .o files cutting build time in half:https://travis-ci.com/github/mcspr/espurna/builds/158421380 (~12-14min)
https://travis-ci.org/github/xoseperez/espurna/builds/631168730 (~27-28min)
But this forces us to use a very strict structure in .ini
TODO:
pio run
right in the python script(
NOTE:
There is another approach that patches platformio internals at runtime:
https://github.com/esphome/esphome/blob/dev/esphome/platformio_api.py
Not sure I want to do that
)