Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need to patch BME680's static library #2429

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Conversation

ruimarinho
Copy link
Contributor

Bosch Sensortec has listened to the community and released a version of their proprietary library which does not require any modification to the linker script.

@mcspr
Copy link
Collaborator

mcspr commented Mar 21, 2021

Idk about the CI, something with the recent PIO changes. I think it either wants an pio update to fetch latest native platform version, or library dependencies break it :/ locally, it works ok
platformio/platform-native#12

Also idk about the new version. I watched the repo (bosch response time is stellar :) and noticed these replacing old blob sizes
boschsensortec/BSEC-Arduino-library@7a93575#diff-61d5bff668b4530537b21e88250797087f2bad8ccb4aa261551665b293aafb62R284
boschsensortec/BSEC-Arduino-library@7a93575#diff-61d5bff668b4530537b21e88250797087f2bad8ccb4aa261551665b293aafb62R303
https://github.com/BoschSensortec/BSEC-Arduino-library/blob/7a9357566c75048331c15b55a4eb20f1de14f36e/src/inc/bsec_datatypes.h#L87
esp loop() runs in a fixed-size 4kb stack, and new version functions eat half of it (and I hope it is only specific to the public part). It should not be a big problem, but I wonder what are the values with ESP.getFreeContStack() + ESP.resetFreeContStack() (reset paints the memory, get searches for the paint to find the border after stack is filled with data)

@mcspr mcspr merged commit bfa704c into xoseperez:dev Mar 31, 2021
@mcspr
Copy link
Collaborator

mcspr commented Mar 31, 2021

re. above. if something breaks - I'd look there :) at least that part of the lib is possible to patch
thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants