Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all led modes in WebUI #458

Closed
xoseperez opened this issue Jan 24, 2018 · 10 comments
Closed

Not all led modes in WebUI #458

xoseperez opened this issue Jan 24, 2018 · 10 comments
Assignees
Labels
Milestone

Comments

@xoseperez
Copy link
Owner

xoseperez commented Jan 24, 2018

Originally reported by: Maxim Prokhorov


Looks like General/LED Mode setting is missing LED_MODE_FOLLOW(2) and
LED_MODE_FOLLOW_INVERSE(3) from the config/general.h

I'm using this with couple of basic sonoffs. Setting ledMode0 to 2 or 3 manually though terminal/telnet causes the select element to become blank. Next time Save from web sets ledMode0 to (null)

@xoseperez
Copy link
Owner Author

Those two modes are there for future reference. The problem is that right now the code is only managing the first LED for notifications, so the available modes refer to "global" status, not per LED or per relay.

LED_MODE_FOLLOW is equivalent to LED_MODE_FINDME but the later takes all relays into consideration.

This is something that will eventually be implemented with version 2, since the goal is to be able to configure basic hardware from the web UI, including the LEDs.

@xoseperez xoseperez added this to the 2.0.0 milestone Jan 25, 2018
@xoseperez xoseperez added enhancement New feature or request and removed bug labels Jan 25, 2018
@mcspr
Copy link
Collaborator

mcspr commented Jan 25, 2018

I see. But if i am reading this right FINDME is actually more like FOLLOW_INVERSE, only for the first relay.
Maybe FINDME_INVERSE makes sense right now? Instead of two FOLLOW and FOLLOW_INVERSE. At least web would not break like this:

default

  1. from web, set led to mqtt managed 0
  2. go to web inspector and swap select values to 2 / set ledMode0 2
  3. save, ledMode0 now 2
    default
  4. refresh, save. ledMode0 now null.

It is mostly an annoyance than a bug, as config system treats null as zero eventually fixing the problem.

@xoseperez
Copy link
Owner Author

Yes, my bad. FINDME is FOLLOW_INVERSE. The idea is that you want the LED on when the switch is off to find it in the dark.

Maybe you could explain why do you need the FINDME_INVERSE mode (so the LED on when any/all switches are on).

@mcspr
Copy link
Collaborator

mcspr commented Jan 25, 2018

As I said - Sonoff Basic. It does not have any indication as POW, or Touch models. I have it screwed to the multi outlet, infrequently powered.

@xoseperez
Copy link
Owner Author

And you want a visual notification when the relay is on? Have you tried the "mixed mode"?

@mcspr
Copy link
Collaborator

mcspr commented Jan 25, 2018

Yeah, but mixed mode is exact opposite, as I want light mostly off. POW turns on blue led when relay switches on, T1 shows each relay via button led. I just felt like this was most sensible setting for device without second led.

@xoseperez
Copy link
Owner Author

I have added the LED_MODE_STATUS that's exactly the opposite the LED_MODE_FINDME. It's in the dev branch now.

@xoseperez xoseperez modified the milestones: 2.0.0, 1.12.2 Jan 27, 2018
@xoseperez xoseperez self-assigned this Jan 27, 2018
@xoseperez
Copy link
Owner Author

Will be released with 1.12.2

@mcspr
Copy link
Collaborator

mcspr commented Jan 28, 2018

Changed all of basics to dev branch with Status mode enabled. Looks great. Thanks!

@xoseperez
Copy link
Owner Author

Cool. Will be released soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants