Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPRIS OpenUri function not implemented #547

Open
Bettehem opened this issue Sep 14, 2022 · 4 comments
Open

MPRIS OpenUri function not implemented #547

Bettehem opened this issue Sep 14, 2022 · 4 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@Bettehem
Copy link

Describe the bug
MPRIS OpenUri function isn't implemented

To Reproduce
Steps to reproduce the behavior:

  1. Try to open a track in Spot by calling the MPRIS OpenUri function, for example by running
    playerctl -p Spot open https://open.spotify.com/track/1Mv6RNqjUuX8ibX349Hgc6
  2. Returns "Could not execute command: GDBus.Error:org.freedesktop.DBus.Error.NotSupported: Not implemented"

Expected behavior
Spot should start playing music based on the given link

General information:

  • Distribution: tested on Arch Linux and Droidian
  • Installation method [e. g. built from source, installed from Flathub...]: built from source
  • Version [e.g. 0.1.0]: 0.3.3
  • Device used [e. g. desktop, phone...]: Desktop PC and Mobile phone

Additional context
I have implemented MPRIS OpenUri support for ncspot too, so I'll probably try adding this myself here too.

@Bettehem Bettehem added the bug Something isn't working label Sep 14, 2022
@Diegovsky
Copy link
Collaborator

I would love to have this actually. Thanks for your report. Would you be willing to open a PR?

@Diegovsky Diegovsky added enhancement New feature or request good first issue Good for newcomers labels Feb 17, 2023
@Bettehem
Copy link
Author

Hi, sorry for my absence. I have been quite busy with work lately, but I'll get it done at some point in the coming weeks when I get a bit of free time.

@Diegovsky
Copy link
Collaborator

Don't worry, any contributions are welcome, at any time :)

@rien333
Copy link

rien333 commented Dec 27, 2023

I probably should open a separate issue, but supplying links directly to spot currently also does not work:

$ spot https://open.spotify.com/track/6t8aRTXXIcx9JVRD8IRZKR

Actually, when doing so, spot shows the notification "Failed to open link!", indicating that it receives the link, but does not know what to do with it.

The same warning notification is shown when I open a spotify url (https://open.spotify.com/track/X) in firefox, while using the Open in Desktop Spotify Client extension.

My guess is that if one would teach spot to open URLs from the commandline, one would automatically gain the ability to open spot by clicking spotify links on the web — provided, of course, that one's browser is configured correctly.

Interestingly, both spot and the "native" spotify linux app register themselves as spotify URL handlers in firefox. This seems to imply that spot already has some kind of OS-level association with spotify-like URLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants